bump trivy version to reduce dependencies #34324

paulcacheux · 2025-02-21T17:49:37Z

What does this PR do?

This PR bumps the trivy version to include:

This results in a big amount of dependencies removed from the agent and system-probe, most notably:

the removal of some DCE blocking dependencies
the removal of container/containerd from system-probe

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2025-02-21T18:03:19Z

Go Package Import Differences

This comment was omitted because it was over 65,536 characters. Please check the Gitlab Job logs to see its output.

agent-platform-auto-pr · 2025-02-21T18:24:50Z

Uncompressed package size comparison

Comparison with ancestor 47fe5ded08d505eb2a4ca389b2f9a8693f034527

Diff per package

package	diff	status	size	ancestor	threshold
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.03MB	62.03MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.10MB	62.10MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.10MB	62.10MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.27MB	59.27MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.34MB	59.34MB	0.50MB
datadog-heroku-agent-amd64-deb	-0.06MB	✅	443.37MB	443.42MB	0.50MB
datadog-agent-aarch64-rpm	-18.53MB	✅	839.99MB	858.52MB	0.50MB
datadog-agent-arm64-deb	-18.53MB	✅	830.24MB	848.77MB	0.50MB
datadog-agent-amd64-deb	-19.01MB	✅	840.15MB	859.16MB	0.50MB
datadog-agent-x86_64-rpm	-19.01MB	✅	849.91MB	868.93MB	0.50MB
datadog-agent-x86_64-suse	-19.01MB	✅	849.91MB	868.93MB	0.50MB

Decision

✅ Passed

agent-platform-auto-pr · 2025-02-21T18:31:58Z

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	813.03MiB	847.49MiB	196.85MiB	212.33MiB
✅	static_quality_gate_agent_deb_arm64	803.41MiB	836.66MiB	178.16MiB	192.5MiB
✅	static_quality_gate_agent_rpm_amd64	813.03MiB	847.82MiB	199.32MiB	215.76MiB
✅	static_quality_gate_agent_rpm_arm64	803.44MiB	836.66MiB	180.81MiB	194.24MiB
✅	static_quality_gate_agent_suse_amd64	812.98MiB	847.82MiB	199.32MiB	215.76MiB
✅	static_quality_gate_agent_suse_arm64	803.42MiB	836.66MiB	180.81MiB	194.24MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	49.7MiB	9.78MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.27MiB	48.1MiB	8.48MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.83MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	897.35MiB	931.7MiB	300.93MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	911.17MiB	944.08MiB	286.43MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.07GiB	1.1GiB	376.03MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.07GiB	1.1GiB	357.53MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.81MiB	57.88MiB	17.28MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	56.27MiB	16.16MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.95MiB	274.78MiB	106.33MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.91MiB	290.82MiB	101.17MiB	111.12MiB

cit-pr-commenter · 2025-02-21T18:51:16Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: faaace1f-3430-4056-8310-32aa5cedd227

Baseline: 47fe5de
Comparison: 667efda
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+1.12	[+1.06, +1.18]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.15	[-0.31, +0.62]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.66, +0.70]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.02	[-0.76, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.81, +0.83]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.30, +0.28]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.78, +0.76]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.64, +0.62]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.08	[-0.85, +0.70]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.08	[-0.84, +0.69]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.30	[-1.22, +0.63]	1	Logs
➖	quality_gate_idle	memory utilization	-1.71	[-1.75, -1.66]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-1.85	[-4.82, +1.12]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-2.66	[-2.71, -2.62]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-3.64	[-3.69, -3.59]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-02-22T21:29:03Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56771227 --os-family=ubuntu

Note: This applies to commit 667efda

YoannGh

Nice one!

paulcacheux · 2025-02-24T15:11:03Z

/merge

dd-devflow · 2025-02-24T15:11:09Z

View all feedbacks in Devflow UI.
2025-02-24 15:11:09 UTC ℹ️ Start processing command /merge

2025-02-24 15:11:14 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

2025-02-24 15:11:33 UTC ❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

#34358 with merge sha af269a3

paulcacheux · 2025-02-24T15:20:18Z

/merge

dd-devflow · 2025-02-24T15:20:25Z

View all feedbacks in Devflow UI.
2025-02-24 15:20:25 UTC ℹ️ Start processing command /merge

2025-02-24 15:20:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-24 17:16:16 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 29m.

2025-02-24 17:44:24 UTC ℹ️ MergeQueue: This merge request was merged

This reverts commit 6a6f052.

github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 21, 2025

github-actions bot added medium review PR review might take time long review PR is complex, plan time to review it and removed short review PR is simple enough to be reviewed quickly medium review PR review might take time labels Feb 21, 2025

paulcacheux force-pushed the paulcacheux/trivy-reduction branch 3 times, most recently from f10b93e to b3a916d Compare February 22, 2025 20:58

github-actions bot added the team/agent-security label Feb 22, 2025

paulcacheux changed the title ~~trivy reduction~~ bump trivy version to reduce dependencies Feb 24, 2025

paulcacheux force-pushed the paulcacheux/trivy-reduction branch from b3a916d to 7b2fcfe Compare February 24, 2025 14:07

paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 24, 2025

paulcacheux marked this pull request as ready for review February 24, 2025 14:08

paulcacheux requested review from a team as code owners February 24, 2025 14:08

YoannGh approved these changes Feb 24, 2025

View reviewed changes

paulcacheux force-pushed the paulcacheux/trivy-reduction branch from 7b2fcfe to 0a8b330 Compare February 24, 2025 15:20

paulcacheux added 2 commits February 24, 2025 17:24

bump trivy

54906e2

do not import "github.com/aquasecurity/trivy/pkg/fanal/image"

667efda

paulcacheux force-pushed the paulcacheux/trivy-reduction branch from 0a8b330 to 667efda Compare February 24, 2025 16:24

dd-mergequeue bot merged commit 6a6f052 into main Feb 24, 2025
241 of 250 checks passed

dd-mergequeue bot deleted the paulcacheux/trivy-reduction branch February 24, 2025 17:44

github-actions bot added this to the 7.65.0 milestone Feb 24, 2025

paulcacheux mentioned this pull request Feb 26, 2025

[build-tags] Delete unused no_dynamic_plugins in system-probe #34474

Merged

purple4reina added a commit that referenced this pull request Feb 27, 2025

Revert "bump trivy version to reduce dependencies (#34324)"

5975cbd

This reverts commit 6a6f052.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump trivy version to reduce dependencies #34324

bump trivy version to reduce dependencies #34324

paulcacheux commented Feb 21, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 21, 2025 •

edited

Loading

Info

cit-pr-commenter bot commented Feb 21, 2025 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

agent-platform-auto-pr bot commented Feb 22, 2025 •

edited

Loading

YoannGh left a comment

paulcacheux commented Feb 24, 2025

dd-devflow bot commented Feb 24, 2025 •

edited

Loading

paulcacheux commented Feb 24, 2025

dd-devflow bot commented Feb 24, 2025 •

edited

Loading

bump trivy version to reduce dependencies #34324

bump trivy version to reduce dependencies #34324

Conversation

paulcacheux commented Feb 21, 2025 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter bot commented Feb 21, 2025 • edited Loading

Go Package Import Differences

agent-platform-auto-pr bot commented Feb 21, 2025 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Feb 21, 2025 • edited Loading

Static quality checks ✅

Info

cit-pr-commenter bot commented Feb 21, 2025 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Feb 22, 2025 • edited Loading

Test changes on VM

YoannGh left a comment

Choose a reason for hiding this comment

paulcacheux commented Feb 24, 2025

dd-devflow bot commented Feb 24, 2025 • edited Loading

paulcacheux commented Feb 24, 2025

dd-devflow bot commented Feb 24, 2025 • edited Loading

paulcacheux commented Feb 21, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 21, 2025 •

edited

Loading

cit-pr-commenter bot commented Feb 21, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Feb 22, 2025 •

edited

Loading

dd-devflow bot commented Feb 24, 2025 •

edited

Loading

dd-devflow bot commented Feb 24, 2025 •

edited

Loading