Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII] Update Go version to 1.21.11 #26360

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

misteriaud
Copy link
Contributor

@misteriaud misteriaud commented Jun 5, 2024

Buildimages update

This PR updates the current buildimages (v34815905-ae40295e ) to v35901572-a9447181, here is the full changelog between:
DataDog/datadog-agent-buildimages@ae40295...a944718

Golang update

This PR updates the current Golang version (1.21.10) to 1.21.11.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.36%. Comparing base (1669607) to head (c32b1d1).
Report is 20 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #26360       +/-   ##
===========================================
+ Coverage   44.96%   51.36%    +6.39%     
===========================================
  Files        2353       27     -2326     
  Lines      272670     2095   -270575     
===========================================
- Hits       122606     1076   -121530     
+ Misses     140395      903   -139492     
+ Partials     9669      116     -9553     
Flag Coverage Δ
amzn_aarch64 51.36% <ø> (+5.55%) ⬆️
centos_x86_64 51.36% <ø> (+5.64%) ⬆️
ubuntu_aarch64 51.36% <ø> (+5.54%) ⬆️
ubuntu_x86_64 51.36% <ø> (+5.55%) ⬆️
windows_amd64 44.82% <ø> (-5.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2024

Regression Detector

Regression Detector Results

Run ID: 31740cb4-bb47-4f0f-9aed-7ad40f7a31bf
Baseline: 1669607
Comparison: c32b1d1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +0.50 [-4.18, +5.19]
uds_dogstatsd_to_api_cpu % cpu utilization +0.15 [-2.84, +3.13]
basic_py_check % cpu utilization +0.12 [-2.86, +3.09]
otel_to_otel_logs ingress throughput +0.04 [-0.33, +0.41]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.04 [-0.08, -0.01]
idle memory utilization -1.16 [-1.20, -1.11]
file_tree memory utilization -2.06 [-2.17, -1.96]
tcp_syslog_to_blackhole ingress throughput -13.15 [-32.76, +6.47]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@misteriaud misteriaud marked this pull request as ready for review June 5, 2024 15:25
@misteriaud misteriaud requested review from a team as code owners June 5, 2024 15:25
@misteriaud misteriaud added [deprecated] team/agent-shared-components Deprecated. Use team/agent-configuration or team/agent-runtimes labels instead. go-update PRs that bump the version of go changelog/no-changelog labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Here are potential matches of the former version:

@misteriaud
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 7, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 27m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 397ca70 into main Jun 7, 2024
242 checks passed
@dd-mergequeue dd-mergequeue bot deleted the buildimages/gobot/go-update-1.21.11 branch June 7, 2024 09:10
@github-actions github-actions bot added this to the 7.55.0 milestone Jun 7, 2024
chouetz pushed a commit that referenced this pull request Dec 19, 2024
Co-authored-by: agent-platform-auto-pr[bot] <agent-platform-auto-pr[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-shared-components Deprecated. Use team/agent-configuration or team/agent-runtimes labels instead. go-update PRs that bump the version of go team/agent-developer-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants