-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlab: use newer builders images #26240
Conversation
/trigger-ci --variable RUN_UNIT_TESTS=on |
🚂 Gitlab pipeline started Started pipeline #35692273 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26240 +/- ##
==========================================
- Coverage 44.97% 44.89% -0.09%
==========================================
Files 2354 2353 -1
Lines 272738 272664 -74
==========================================
- Hits 122668 122410 -258
- Misses 140402 140583 +181
- Partials 9668 9671 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regression DetectorRegression Detector ResultsRun ID: eeb8f7d6-266d-42c7-8c50-b8211671cf57 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +22.74 | [-0.47, +45.95] |
➖ | otel_to_otel_logs | ingress throughput | +0.16 | [-0.21, +0.53] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.18, +0.22] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.01 | [-4.69, +4.72] |
➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.02] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.08 | [-0.12, -0.04] |
➖ | idle | memory utilization | -0.12 | [-0.17, -0.07] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.19 | [-3.17, +2.79] |
➖ | file_tree | memory utilization | -0.23 | [-0.33, -0.14] |
➖ | basic_py_check | % cpu utilization | -1.34 | [-4.26, +1.58] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/trigger-ci --variable RUN_UNIT_TESTS=on |
🚂 Gitlab pipeline started Started pipeline #35783884 |
/trigger-ci --variable RUN_UNIT_TESTS=on |
🚂 Gitlab pipeline started Started pipeline #35784011 |
/trigger-ci --variable RUN_UNIT_TESTS=on |
🚂 Gitlab pipeline started Started pipeline #35787842 |
🚂 Devflow: |
[Fast Unit Tests Report] On pipeline 36024080 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
Done by #26360 already. |
APR-94
What does this PR do?
Fixes
unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000
when using thelibsds_go.so
library on rpm-arm64.Describe how to test/QA your changes
tests_rpm-arm64
anymore.