Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: use newer builders images #26240

Closed
wants to merge 4 commits into from
Closed

gitlab: use newer builders images #26240

wants to merge 4 commits into from

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Jun 3, 2024

APR-94

What does this PR do?

Fixes unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000 when using the libsds_go.so library on rpm-arm64.

Describe how to test/QA your changes

  • Validate that this warning doesn't appear in the tests_rpm-arm64 anymore.

@remeh
Copy link
Contributor Author

remeh commented Jun 3, 2024

/trigger-ci --variable RUN_UNIT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 3, 2024

🚂 Gitlab pipeline started

Started pipeline #35692273

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.89%. Comparing base (d224b9a) to head (2b6c409).

Current head 2b6c409 differs from pull request most recent head e7a0bfa

Please upload reports for the commit e7a0bfa to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26240      +/-   ##
==========================================
- Coverage   44.97%   44.89%   -0.09%     
==========================================
  Files        2354     2353       -1     
  Lines      272738   272664      -74     
==========================================
- Hits       122668   122410     -258     
- Misses     140402   140583     +181     
- Partials     9668     9671       +3     
Flag Coverage Δ
amzn_aarch64 45.74% <ø> (-0.07%) ⬇️
centos_x86_64 45.64% <ø> (-0.08%) ⬇️
ubuntu_aarch64 45.74% <ø> (-0.08%) ⬇️
ubuntu_x86_64 45.73% <ø> (-0.08%) ⬇️
windows_amd64 50.71% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024

Regression Detector

Regression Detector Results

Run ID: eeb8f7d6-266d-42c7-8c50-b8211671cf57
Baseline: 4335d82
Comparison: 2b6c409

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +22.74 [-0.47, +45.95]
otel_to_otel_logs ingress throughput +0.16 [-0.21, +0.53]
uds_dogstatsd_to_api ingress throughput +0.02 [-0.18, +0.22]
pycheck_1000_100byte_tags % cpu utilization +0.01 [-4.69, +4.72]
trace_agent_json ingress throughput +0.01 [-0.01, +0.02]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.08 [-0.12, -0.04]
idle memory utilization -0.12 [-0.17, -0.07]
uds_dogstatsd_to_api_cpu % cpu utilization -0.19 [-3.17, +2.79]
file_tree memory utilization -0.23 [-0.33, -0.14]
basic_py_check % cpu utilization -1.34 [-4.26, +1.58]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@remeh remeh changed the title gitlab: use newer rpm-arm64 builders gitlab: use newer builders images Jun 4, 2024
@remeh
Copy link
Contributor Author

remeh commented Jun 4, 2024

/trigger-ci --variable RUN_UNIT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 Gitlab pipeline started

Started pipeline #35783884

@remeh
Copy link
Contributor Author

remeh commented Jun 4, 2024

/trigger-ci --variable RUN_UNIT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 Gitlab pipeline started

Started pipeline #35784011

@remeh remeh force-pushed the remeh/arm64-sds branch from ab63fd6 to cc76f66 Compare June 4, 2024 11:59
@remeh
Copy link
Contributor Author

remeh commented Jun 4, 2024

/trigger-ci --variable RUN_UNIT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 Gitlab pipeline started

Started pipeline #35787842

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 Devflow: /trigger-ci --variable RUN_UNIT_TESTS=on

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 36024080 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@remeh
Copy link
Contributor Author

remeh commented Jun 11, 2024

Done by #26360 already.

@remeh remeh closed this Jun 11, 2024
@dd-devflow dd-devflow bot deleted the remeh/arm64-sds branch December 6, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants