Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show error while creating table or model #1250

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented Sep 30, 2024

  • Shows error for the duplicate model name issue
  • Also fixes a bug in the newly released drop column form

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (c9b2d91) to head (592090b).

Files with missing lines Patch % Lines
...mponents/OperationPanel/Forms/DropColumnOpForm.tsx 20.00% 4 Missing ⚠️
...omponents/OperationPanel/Forms/CreateTableForm.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   69.47%   69.45%   -0.02%     
==========================================
  Files          97       97              
  Lines        6967     6973       +6     
  Branches     1690     1693       +3     
==========================================
+ Hits         4840     4843       +3     
+ Misses       2087     2002      -85     
- Partials       40      128      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishankoradia Ishankoradia merged commit 45ecbd3 into main Sep 30, 2024
3 of 5 checks passed
@Ishankoradia Ishankoradia deleted the bug/duplicate-models-error branch September 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants