Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/duplicate model name #870

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Bug/duplicate model name #870

merged 2 commits into from
Sep 30, 2024

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented Sep 30, 2024

Fixes DalgoT4D/webapp#1247

Webapp- DalgoT4D/webapp#1250

Dbt model names need to be unique. Fix handles these cases

  • When the model is materialized and we go & edit an operation to re-save the model. This action should not allow them to create a model with same name but different schema.
  • When there is a separate chain but you try to save the model with the same name (any schema, deosn't matter). This action should not be allowed

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.50%. Comparing base (d98beb8) to head (0709ae6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ddpui/api/transform_api.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   69.51%   69.50%   -0.02%     
==========================================
  Files          76       76              
  Lines        7023     7027       +4     
==========================================
+ Hits         4882     4884       +2     
- Misses       2141     2143       +2     
Flag Coverage Δ
69.50% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishankoradia Ishankoradia merged commit e8329a6 into main Sep 30, 2024
2 of 4 checks passed
@Ishankoradia Ishankoradia deleted the bug/duplicate-model-name branch September 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Resolve Duplicate Table Issue
2 participants