Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-7_x] Get rid of unnecessary and failing REST requests when navigating between different browse indexes #3788

Conversation

jensvannerum
Copy link
Contributor

This is a backport of #3753 to 7.x

@alanorth
Copy link
Contributor

Thanks @jensvannerum. This is failing due to unused imports. Could be something that was added in DSpace 8+ that we don't need here.

@jensvannerum jensvannerum force-pushed the w2p-121787_Investigate-internal-server-error-on-browse-page-experiment-7.x branch from 14c623d to db10200 Compare December 31, 2024 08:40
@alanorth alanorth added this to the 7.6.3 milestone Jan 1, 2025
@alanorth
Copy link
Contributor

alanorth commented Jan 1, 2025

Thanks @jensvannerum. I have tested the patch on DSpace 7.6 and it fixes the bug. Seeing as this is a simple port of #3753 and it's passing all tests in CI and my manual test, I will merge this. I will squash the commits into one though since it is one functional change.

@alanorth alanorth merged commit 33fdee5 into DSpace:dspace-7_x Jan 1, 2025
15 checks passed
@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system high priority 1 APPROVAL pull request only requires a single approval to merge labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system high priority
Projects
Development

Successfully merging this pull request may close these issues.

3 participants