Get rid of unnecessary and failing REST requests when navigating between different browse indexes

[jensvannerum]

References

• Fixes Hitting browse by author from by issue date gets server error #573

Description

• Destroys and reconstructs the browse component when the route changes so that any route change calls ngOnInit in the browse-by component, this way we can be sure that we only care about the first value of the route (necessary for our take(1) in subscription)
  • in the browse-by-page-componentthe type is wrapped in an object so a change from one browse index to another browse index of the same type still causes a lifecycle trigger (since objects are compared by identity).

You could argue that performance wise we don't want to re-build the component every time but any performance gains that this would offer is lost by the multiple useless requests I think

Instructions for Reviewers

• Set this angular branch up against latest main / demo instance
• Open any browse index and switch to other browse indexes while having the 'Network' tab open in developer tools
• Notice no unnecessary requests are being sent and no failing requests are present either (compare to eg current demo.dspace.org)
• Verify browse indexes still work as before including pagination, filtering, ordering thumbnails, etc...

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[alanorth]

Thanks, @jensvannerum. I tested this by navigating to the Browse By Date on sandbox.dspace.org with the network panel open, then switching to Browse by Author.

Before, I see HTTP 500 errors:

After, I see only HTTP 200:

I see some changes to the menu resolver regarding authentication. Was that intentional? Also, I think we should squash these changes to avoid the unnecessary modifications and fixes to packages. Those don't need to live in git forever.

[tdonohue]

@jensvannerum : This PR appears to have failing tests. Could you look into it when you have a chance? Thanks!

[jensvannerum]

@tdonohue I fixed specs and squashed all commits in to one against the latest main branch for a cleaner git history

[jensvannerum]

@alanorth

I see some changes to the menu resolver regarding authentication. Was that intentional? Also, I think we should squash these changes to avoid the unnecessary modifications and fixes to packages. Those don't need to live in git forever.

Yes these were intentional since these also sent a bunch of requests to check if we're authenticated here for example:

      this.authorizationService.isAuthorized(FeatureID.IsCollectionAdmin),
      this.authorizationService.isAuthorized(FeatureID.IsCommunityAdmin),
      this.authorizationService.isAuthorized(FeatureID.AdministratorOf),
      this.authorizationService.isAuthorized(FeatureID.CanSubmit),
      this.authorizationService.isAuthorized(FeatureID.CanEditItem),
      this.authorizationService.isAuthorized(FeatureID.CanSeeQA),
      this.authorizationService.isAuthorized(FeatureID.CoarNotifyEnabled),

Although these are not 100% related to the browse pages specifically, there's no point in sending these requests if we're not authenticated in any way I think.

[alanorth]

Thanks @jensvannerum. This looks good now, all tests passing and with one clean commit. I gave it another test just to be sure, and the HTTP 500 errors are gone when switching between browses, both as an anonymous user and as an admin.

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3753-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3753-to-dspace-7_x
git switch --create backport-3753-to-dspace-7_x
git cherry-pick -x a105bcd6f45d8e85844cd473964670e1461b29cf

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] Get rid of unnecessary and failing REST requests when navigating between different browse indexes  #3764

[alanorth]

Dear @jensvannerum, the automatic backport to dspace-7_x failed. If you have time would you be able to manually port it? This fix would be nice to have on DSpace 7.x as well. Thanks!

[jensvannerum]

7.x backport in #3788