dcm2mha preprocessing #5
Conversation
| @@ -36,6 +37,8 @@ def __init__( | |||
| input_path: PathLike, | |||
| output_path: PathLike, | |||
| settings_path: PathLike, | |||
| verify_dicom_filenames: bool = True, | |||
| scan_postprocess_func: Optional[Callable[[sitk.Image], sitk.Image]] = None, | |||
There was a problem hiding this comment.
Request to minimize the number of complicated non-obvious parameters of the constructor, and instead plop these in a **kwargs. so kwargs.get('verify_dicom_filenames', True) instead
There was a problem hiding this comment.
Furthermore, if put in a self.kwargs for example, these can be consumed at an arbitrary point during processing
There was a problem hiding this comment.
I agree, but better to make a settings class for it. That way, the available settings are clear and can be checked upon initialisation.
There was a problem hiding this comment.
Let's tackle this in the Item refactoring?
|
|
||
| self.info(f"Collected {plural(total, 'DICOM file')} from {self.valid_items_str()}.", self.get_history_report()) | ||
|
|
||
| @staticmethod |
There was a problem hiding this comment.
Stacked functions make it difficult to follow what's going on, so it there is no benefit, better to keep it simple.
Implemented: