refactor/#4 Refactor for boolean var and remove unit test

DD2480-Group-22 · Feb 28, 2020 · ef7d9b3 · ef7d9b3
1 parent 3e05a47
commit ef7d9b3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 62 deletions.
diff --git a/src/main/java/org/jabref/gui/preferences/PreviewTabViewModel.java b/src/main/java/org/jabref/gui/preferences/PreviewTabViewModel.java
@@ -184,9 +184,9 @@ public void storeSettings() {
             chosenListProperty.add(previewPreferences.getTextBasedPreviewLayout());
         }
 
-        if (!previewPreferences.showPreviewAsExtraTab && showAsExtraTab.getValue() ) {
+        if (!previewPreferences.getShowPreviewAsExtraTab() && showAsExtraTab.getValue() ) {
             restartWarnings.add(Localization.lang("Preview separate tab enabled"));
-        } else if (previewPreferences.showPreviewAsExtraTab && !showAsExtraTab.getValue() ) {
+        } else if (previewPreferences.getShowPreviewAsExtraTab() && !showAsExtraTab.getValue() ) {
             restartWarnings.add(Localization.lang("Preview separate tab disabled"));
 
         }

diff --git a/src/main/java/org/jabref/preferences/PreviewPreferences.java b/src/main/java/org/jabref/preferences/PreviewPreferences.java
@@ -14,7 +14,7 @@ public class PreviewPreferences {
     private final Number previewPanelDividerPosition;
     private final String previewStyle;
     private final String previewStyleDefault;
-    public final boolean showPreviewAsExtraTab;
+    private final boolean showPreviewAsExtraTab;
 
     public PreviewPreferences(List<PreviewLayout> previewCycle, int previewCyclePosition, Number previewPanelDividerPosition, String previewStyle, String previewStyleDefault, boolean showPreviewAsExtraTab) {
         this.previewCycle = previewCycle;
@@ -25,6 +25,10 @@ public PreviewPreferences(List<PreviewLayout> previewCycle, int previewCyclePosi
         this.showPreviewAsExtraTab = showPreviewAsExtraTab;
     }
 
+    public boolean getShowPreviewAsExtraTab() {
+        return showPreviewAsExtraTab;
+    }
+
     public List<PreviewLayout> getPreviewCycle() {
         return previewCycle;
     }

diff --git a/src/test/java/org/jabref/gui/preferences/previewTabViewTest.java b/src/test/java/org/jabref/gui/preferences/previewTabViewTest.java