v10.6.0 #2590
v10.6.0 #2590
Conversation
ouziel-slama
commented
Oct 25, 2024
•
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
Fix Lock File Not Found Error
[v10.6.0] Only Require One Valid Dispenser in Validation Logic
Fix chained utxos moves during catch up
Bump Version; Add checkpoint
| logger.debug("No block fetched. Waiting before next fetch.") | ||
| time.sleep(random.uniform(0.2, 0.7)) # noqa: S311 | ||
| # Use Event's wait method instead of time.sleep for better responsiveness | ||
| self.stopped_event.wait(timeout=random.uniform(0.2, 0.7)) # noqa: S311 |
Check notice
Code scanning / Bandit
Standard pseudo-random generators are not suitable for security/cryptographic purposes. Note
| @@ -392,74 +392,94 @@ | |||
| return app | |||
|
|
|||
|
|
|||
| def run_api_server(args, interrupted_value, server_ready_value): | |||
| def run_api_server(args, server_ready_value, stop_event): | |||
Check warning
Code scanning / pylint
Unused argument 'stop_event'. Warning
| jsonrpc_response = jsonrpc.exceptions.JSONRPCServerError( | ||
| message=exception_name, data=exception_text | ||
| ) | ||
| CURRENT_API_STATUS_CODE = code |
Check warning
Code scanning / pylint
Using variable 'code' before assignment. Warning
| @@ -652,7 +652,7 @@ | |||
| cursor.execute(sql, event_bindings) | |||
|
|
|||
|
|
|||
| def parse_event(api_db, event, catching_up=False): | |||
| def parse_event(api_db, event, watcher, catching_up=False): | |||
Check warning
Code scanning / pylint
Unused argument 'catching_up'. Warning
| @@ -803,8 +803,8 @@ | |||
| return event | |||
|
|
|||
|
|
|||
| def synchronize_mempool(api_db, ledger_db): | |||
| if config.NO_MEMPOOL: | |||
| def synchronize_mempool(api_db, ledger_db, stop_event): | |||
Check warning
Code scanning / pylint
Too many branches (16/12). Warning
| @@ -666,7 +675,14 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| def compose_movetoutxo(db, utxo: str, destination: str, more_utxos: str = ""): | |||
| def compose_movetoutxo( | |||
Check warning
Code scanning / pylint
Too many positional arguments (6/5). Warning
| try: | ||
| check.asset_conservation(self.db, self.stop_event) | ||
| except check.SanityError as e: | ||
| logger.error("Asset conservation check failed: %s" % e) |
Check warning
Code scanning / pylint
Formatting a regular string which could be an f-string. Warning
| @@ -733,8 +723,21 @@ | |||
| asset_conservation_checker = None | |||
| db = None | |||
|
|
|||
| # Log all config parameters, sorted by key | |||
| # Filter out default values #TODO: these should be set in a different way | |||
Check warning
Code scanning / pylint
Filter out default values #TODO: these should be set in a different way. Warning
| } | ||
| logger.debug(f"Config: {custom_config}") | ||
|
|
||
| def handle_interrupt_signal(signum, frame): |
Check warning
Code scanning / pylint
Redefining name 'handle_interrupt_signal' from outer scope (line 49). Warning
| } | ||
| logger.debug(f"Config: {custom_config}") | ||
|
|
||
| def handle_interrupt_signal(signum, frame): |
Check warning
Code scanning / pylint
Unused argument 'signum'. Warning
| } | ||
| logger.debug(f"Config: {custom_config}") | ||
|
|
||
| def handle_interrupt_signal(signum, frame): |
Check warning
Code scanning / pylint
Unused argument 'frame'. Warning
Add `get_asset` and `give_asset` arguments for Get Orders endpoint
|
|
||
|
|
||
| def get_orders( | ||
| db, | ||
| status: OrderStatus = "all", | ||
| get_asset: str = None, |
Check warning
Code scanning / pylint
Redefining name 'get_asset' from outer scope (line 2472). Warning
Fix `--bootstrap-url` flag with `start` command
Merge pull request #2531 from CounterpartyXCP/develop
Merge pull request #2590 from CounterpartyXCP/develop