Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.6.0] Only Require One Valid Dispenser in Validation Logic #2575

Merged
merged 8 commits into from
Oct 24, 2024
Merged

[v10.6.0] Only Require One Valid Dispenser in Validation Logic #2575

merged 8 commits into from
Oct 24, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 24, 2024 •
edited
Loading

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

adamkrellenstein
adamkrellenstein approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@adamkrellenstein adamkrellenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need release notes!

adamkrellenstein
adamkrellenstein requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@adamkrellenstein adamkrellenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and tests for these cases

@adamkrellenstein adamkrellenstein mentioned this pull request Oct 24, 2024
Closed
@adamkrellenstein adamkrellenstein changed the title [v11.x.y] Accept only one valid dispenser [v10.6.0] Accept only one valid dispenser Oct 24, 2024
@adamkrellenstein adamkrellenstein changed the title [v10.6.0] Accept only one valid dispenser [v11.0.0] Accept only one valid dispenser Oct 24, 2024
@adamkrellenstein adamkrellenstein changed the title [v11.0.0] Accept only one valid dispenser [v11.0.0] Only Require One Valid Dispenser in Validation Logic Oct 24, 2024
@adamkrellenstein adamkrellenstein changed the title [v11.0.0] Only Require One Valid Dispenser in Validation Logic [v10.6.0] Only Require One Valid Dispenser in Validation Logic Oct 24, 2024
@ouziel-slama
Copy link
Contributor Author

and tests for these cases

regtest test added

@adamkrellenstein adamkrellenstein merged commit cf1f80d into develop Oct 24, 2024
17 checks passed
@adamkrellenstein adamkrellenstein deleted the fixcomposedispense branch October 24, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.6.0 (Hotfix Multiple Dispensers)
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel