Code

Thumbwheel fixes and improvements#2660

Code

Merged

shroffk merged 20 commits intomasterControlSystemStudio/phoebus:masterfrom CSSTUDIO-1872ControlSystemStudio/phoebus:CSSTUDIO-1872Copy head branch name to clipboardMay 2, 2023

+188-574

Commits

Commits on Apr 20, 2023

• CSSTUDIO-1872 Fix: don't write back values received from the PV to the PV.

  abrahamwolk

  committed
  be1fabc

  Copy full SHA for be1fabc

• CSSTUDIO-1872 Rename thumbwheelValueChanged() to writeValueToPV(). Update description.

  abrahamwolk

  committed
  fee7cc4

  Copy full SHA for fee7cc4

Commits on Apr 21, 2023

• CSSTUDIO-1872 Remove min and max limits. Instead, display "invalid" value when value cannot be represented either due to too many integer decimals or no sign available to display negative values.

  abrahamwolk

  committed
  ccc69fd

  Copy full SHA for ccc69fd

Commits on Apr 26, 2023

• CSSTUDIO-1872 Initialize the Thumbwheel widget only using the constructor, instead of both through using the constructor and the initializer. Also, disable buttons when in edit mode.

  abrahamwolk

  committed
  a7b7e40

  Copy full SHA for a7b7e40

• CSSTUDIO-1872 Add option to the widget editor to control whether negative numbers can be represented or not in the widget.

  abrahamwolk

  committed
  629bb0a

  Copy full SHA for 629bb0a

Commits on Apr 27, 2023

• CSSTUDIO-1872 Fix scrolling.

  abrahamwolk

  committed
  b2a8fe4

  Copy full SHA for b2a8fe4

• CSSTUDIO-1872 Remove the options "Minimum", "Maximum", and "Limits from PV" from the widget.

  abrahamwolk

  committed
  afa0935

  Copy full SHA for afa0935

• CSSTUDIO-1872 Remove commented-out code.

  abrahamwolk

  committed
  3363ed2

  Copy full SHA for 3363ed2

• CSSTUDIO-1872 Remove unused code and remove unused clamping functionality.

  abrahamwolk

  committed
  9b166bd

  Copy full SHA for 9b166bd

• CSSTUDIO-1914 Update default color scheme.

  abrahamwolk

  committed
  f6b8cdc

  Copy full SHA for f6b8cdc

• CSSTUDIO-1872 Remove unused variable.

  abrahamwolk

  committed
  2b8457e

  Copy full SHA for 2b8457e

Commits on Apr 28, 2023

• CSSTUDIO-1872 Add a transparent "Region" to prevent buttons on widget from being clickable in edit mode.

  abrahamwolk

  committed
  8a2289b

  Copy full SHA for 8a2289b

• CSSTUDIO-1872 Remove unused field "isEditMode".

  abrahamwolk

  committed
  da20162

  Copy full SHA for da20162

• CSSTUDIO-1872 Use the same distance between the buttons regardless of the symbols used on the buttons.

  abrahamwolk

  committed
  638c172

  Copy full SHA for 638c172

Commits on May 2, 2023

• CSSTUDIO-1915 Implement automatic resizing of the icons on the buttons when the widget is resized.

  abrahamwolk

  committed
  5f53770

  Copy full SHA for 5f53770

• CSSTUDIO-1915 Implement automatic adjustment of the size of the margins at the borders and between the +/- buttons when the widget is resized.

  abrahamwolk

  committed
  93cfae4

  Copy full SHA for 93cfae4

• CSSTUDIO-1872 Don't display the value written to the PV in the widget. (Instead, always display the latest update received from the PV.)

  abrahamwolk

  committed
  59841df

  Copy full SHA for 59841df

• CSSTUDIO-1872 Remove the option to enable scrolling.

  abrahamwolk

  committed
  5e3428f

  Copy full SHA for 5e3428f

• CSSTUDIO-1872 Fix error message.

  abrahamwolk

  committed
  6a26017

  Copy full SHA for 6a26017

• CSSTUDIO-1872 Fix description.

  abrahamwolk

  committed
  a26db32

  Copy full SHA for a26db32