Thumbwheel fixes and improvements #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
georgweiss
commented
May 2, 2023
- PV not written again when picking up monitor update
- Button symbols resized together with widget
- Color scheme aligned with other widgets
…date description.
…alue when value cannot be represented either due to too many integer decimals or no sign available to display negative values.
…ctor, instead of both through using the constructor and the initializer. Also, disable buttons when in edit mode.
…tive numbers can be represented or not in the widget.
…om PV" from the widget.
… from being clickable in edit mode.
… the symbols used on the buttons.
…s when the widget is resized.
…ns at the borders and between the +/- buttons when the widget is resized.
…. (Instead, always display the latest update received from the PV.)
shroffk
approved these changes
May 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.