app-alarm-ui Automated Actions Gui enhancement suggestion #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve maven dependency on core-security issue ControlSystemStudio#2331 Best practice on Transitive Maven dependency see https://guides.dataverse.org/en/latest/developers/dependencies.html
|
Can you keep the change to just TitleDetailDelayTable , without the pom.xml changes? |
Yes of course. I will suggest another modification by replacing TextField editor for the delay by a Spinner. |
|
Looks good. Will wait for the test build to complete, then merge |
|
Now it's seems to be OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing simple Textfield detail column by 2 columns :
The detail property will built as following option:info
See the following screenshot to see the difference
One classe modified
https://github.com/katysaintin/phoebus/blob/master/app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/TitleDetailDelayTable.java