Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-alarm-ui Automated Actions Gui enhancement suggestion #2335

Closed
katysaintin opened this issue Jul 22, 2022 · 6 comments
Closed

app-alarm-ui Automated Actions Gui enhancement suggestion #2335

katysaintin opened this issue Jul 22, 2022 · 6 comments

Comments

@katysaintin
Copy link
Contributor

app-alarm-ui Automated Actions Gui enhancement suggestion

By replacing simple Textfield detail column by 2 columns :

  • A combobox to select email or cmd
  • A textfield to define the information (email or command)

The detail property will built as following option:info
See the following screenshot to see the difference
AutomateActionsSuggestion

I will push my code modification on my Fork https://github.com/katysaintin/phoebus

katysaintin added a commit to katysaintin/phoebus that referenced this issue Jul 22, 2022
@kasemir
Copy link
Collaborator

kasemir commented Jul 22, 2022

Since you already support mailto: and cmd:, can you also support sevrpv:?
See https://github.com/ControlSystemStudio/phoebus/blob/master/app/alarm/ui/doc/index.rst

@katysaintin
Copy link
Contributor Author

Since you already support mailto: and cmd:, can you also support sevrpv:? See https://github.com/ControlSystemStudio/phoebus/blob/master/app/alarm/ui/doc/index.rst

I miss this one, Ok I will add to my suggestion.

katysaintin added a commit to katysaintin/phoebus that referenced this issue Jul 22, 2022
@katysaintin
Copy link
Contributor Author

I have just add it (I use a combobox on enumeration)
AutomateActionsSuggestion

@katysaintin
Copy link
Contributor Author

There is only a modification in one classe in app-alarm-ui . Do you think I can propose my modifcation as a pull request ?
https://github.com/katysaintin/phoebus/blob/master/app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/TitleDetailDelayTable.java

@kasemir
Copy link
Collaborator

kasemir commented Jul 22, 2022

Yes, go ahead and create a PR

@kasemir
Copy link
Collaborator

kasemir commented Jul 26, 2022

update had been merged

@kasemir kasemir closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants