Ensure that all operations emit correct amounts #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure that all operations emit correct amounts such that the
check:data
check of the Rosetta CLI tool passes.Changes
Many operation types had amount in their metadata instead of the operation itself. And for some odd reason, they had the fee as their amount which cancelled out the fee operation...
The following changes were included as part of this:
The changes have been picked from #24 to have a working version for P3, but also because the changes are mostly irrelevant for that PR.
Checklist
hard-to-understand areas.