Upgrade Node SDK to version supporting P4 #24
Conversation
# Conflicts: # Cargo.lock
|
@abizjak I believe this is ready for final review. A full check is running against testnet but there were some issues keeping it running. I'll let it at least traverse a significant portion of the chain without error before merging. |
| struct DelegationSetDelegationTargetMetadata { | ||
| delegator_id: DelegatorId, | ||
| delegation_target: String, | ||
| } |
There was a problem hiding this comment.
I don't understand why you don't need "Resumed" and "Interrupted" events (for contracts), but you do need these. Is that deliberate, or an omission?
There was a problem hiding this comment.
Is this comment where it should be?
There was a problem hiding this comment.
And still relevant?
There was a problem hiding this comment.
It is kind of in the right place. I still don't quite understand why those events are not needed.
There was a problem hiding this comment.
These structs are just metadata, i.e. extra information that applications/users may care about but rosetta doesn't. Filed #38 for including it later on.
Co-authored-by: Aleš Bizjak <abizjak@users.noreply.github.com>
Purpose
Support new protocol version.
Changes
Upgrade SDK.
Resolves #16.