Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend particle assign specialization #615

Merged
merged 3 commits into from
Jan 3, 2015
Merged

extend particle assign specialization #615

merged 3 commits into from
Jan 3, 2015

Conversation

psychocoderHPC
Copy link
Member

  • add functor to set an attribute of a particle to their default value
  • extend the particle assign definition (set attributes which are not defined in the source particle to their default value) discussion
  • remove old usage of SetValueToDefault with the new PMacc functor

Tests

  • runtime: KHI
  • compile time: check subset and complementary sequence with various configurations

@psychocoderHPC
add particle operation, extend particle assign
971b5bf 
- add functor to set an attribute of a particle to their default value
- extend the particle assign definition (set attributes which are not defined in the source particle to their default value)
@psychocoderHPC
delete SetToDefault and use PMacc version
5b4e2ef 
- use new method SetAttributeToDefault() from PMacc
- delete local method SetToDefault
- use new method SetAttributeToDefault() in all single particle examples
@psychocoderHPC psychocoderHPC force-pushed the topic-extendAssignParticle branch from 08d445f to 5b4e2ef Compare December 19, 2014 20:40
@psychocoderHPC psychocoderHPC mentioned this pull request Dec 19, 2014
Merged
10 tasks
@psychocoderHPC psychocoderHPC added this to the Open Beta milestone Dec 19, 2014
ax3l
ax3l reviewed Dec 19, 2014
View reviewed changes
src/libPMacc/include/particles/memory/dataTypes/Particle.hpp
@@ -157,6 +161,9 @@ namespace operations
namespace detail
{

/** Assign all attributes from a particle out of another one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion:

/** Assign common attributes of two particle species
 *
 * Assigns all attributes in ValueTypeSeq1 that also exist in T_ValueTypeSeq2
 * from T_FrameType1 to T_FrameType2.
 */

@ax3l
Copy link
Member

ax3l commented Dec 19, 2014

Pretty and elegant pull request!
I just added minors to clarify the doc strings.

ax3l
ax3l reviewed Dec 19, 2014
View reviewed changes
src/libPMacc/include/particles/memory/dataTypes/Particle.hpp

/** Assign particle attributes
*
* The subset of the attribute lists from both particles is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The common subset [...]

@psychocoderHPC
Copy link
Member Author

@ax3l Thx for your annotations. I inserted all of them and updated my pull request.

@ax3l
Copy link
Member

ax3l commented Jan 3, 2015

well done, thanks!

ax3l added a commit that referenced this pull request Jan 3, 2015
@ax3l
Merge pull request #615 from psychocoderHPC/topic-extendAssignParticle
49bb7e3 
extend particle assign specialization
@ax3l ax3l merged commit 49bb7e3 into ComputationalRadiationPhysics:dev Jan 3, 2015
@psychocoderHPC psychocoderHPC deleted the topic-extendAssignParticle branch January 3, 2015 20:18
n01r pushed a commit to n01r/picongpu that referenced this pull request Jan 7, 2015
Use Resolve<> trait , make new attribute lists
d0de4a6 
In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization
algorithm to the used model.

Furthermore new attribute lists for the different species have been introduced.
Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615.

Prettying up comments
n01r pushed a commit to n01r/picongpu that referenced this pull request Jan 7, 2015
Use Resolve<> trait , make new attribute lists
54f0d47 
In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization
algorithm to the used model.

Furthermore new attribute lists for the different species have been introduced.
Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615.

Prettying up comments
n01r pushed a commit to n01r/picongpu that referenced this pull request Jan 15, 2015
Use Resolve<> trait , make new attribute lists
c229069 
In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization
algorithm to the used model.

Furthermore new attribute lists for the different species have been introduced.
Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615.

Prettying up comments
n01r pushed a commit to n01r/picongpu that referenced this pull request Jan 21, 2015
Use Resolve<> trait , make new attribute lists
bd2f768 
In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization
algorithm to the used model.

Furthermore new attribute lists for the different species have been introduced.
Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615.

Prettying up comments
n01r pushed a commit to n01r/picongpu that referenced this pull request Feb 4, 2015
Use Resolve<> trait , make new attribute lists
f25ea9d 
In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization
algorithm to the used model.

Furthermore new attribute lists for the different species have been introduced.
Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615.

Prettying up comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ax3l ax3l

Labels
component: PMacc in PMacc
Projects
None yet
Milestone
0.2.0: Open Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@psychocoderHPC @ax3l