remove `::ThisType` in all identifier types #594

psychocoderHPC · 2014-12-04T09:26:26Z

follow up of #593

remove bad ::ThisType in all Identifier
use new trait Resolve<T> to get the type which is represented by an alias

~~please do not merge before #593~~

this trait gives the real type of an alias

- change `alias` remove inherit - use new trait `Resolve<T>` to handle incomplete types

- change documentation of `alias` - remove block of boost 1.56.0+ versions in CMakeLists

remove `ThisType` (know available with the trait `Resolve<T>`)

use new trait `Resolve<T>` to get the type out of an alias

psychocoderHPC · 2014-12-04T09:29:52Z

@n01r This pull is important for your next rebase session.

n01r · 2014-12-04T10:23:24Z

src/libPMacc/include/traits/Resolve.hpp

+/** Get resolved type
+ *
+ * Explicitly resolve the type of a synonym type, e.g., resolve the type of an PMacc alias.
+ * A synonym type is wrapper type (class) around an other type.


Typos: A synonym type is a wrapper type (class) around another type.

n01r · 2014-12-04T10:30:58Z

Maybe it is the wrong place to ask this but wouldn't it be cool if this trait could also be used for debugging? I'm thinking of an optional variable one can set active for each instance of Resolve<T> so that it does not only resolve the type but also prints it with some kind of compile time static assert magic message during the compile process?

ax3l · 2014-12-08T18:01:50Z

@psychocoderHPC If you adress the two last open questions I can merge it.

psychocoderHPC · 2014-12-08T18:29:47Z

I am sick :-( I fix all as fast as possible.

ax3l · 2014-12-08T18:32:03Z

ohoh, get well soon 🎮 😴

n01r · 2014-12-09T12:58:41Z

Drink much ginger tea 😉

ax3l · 2014-12-10T07:05:51Z

@psychocoderHPC I think that pull is rdy to be merged.

can you pls just answer the questions of @n01r ? (probably out of this pull anyway).

psychocoderHPC · 2014-12-10T10:20:18Z

@n01r it is only possible to exit with an error to write out compile time information. If you need that than you can define the trait for your own user type and use cassert_msg_type to write out some informations.

n01r · 2014-12-10T10:30:01Z

Hmm but do you think it would be possible to do that generically?
Seems to me like a nice tool to find your way through the often dark PIConGPU forest. 😝
I could try myself out on that while I wait for #594 and #596 to be merged.

psychocoderHPC · 2014-12-10T10:42:07Z

The only generic way is that you specialize the trait and add all stuff you need.

n01r · 2014-12-10T10:45:54Z

Hmm, alright - maybe I will try that. But it will not have priority - if I come up with anything cool you will get to know.
So I guess this can be merged now.

remove `::ThisType` in all identifier types

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization algorithm to the used model. Furthermore new attribute lists for the different species have been introduced. Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615. Prettying up comments

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization algorithm to the used model. Furthermore new attribute lists for the different species have been introduced. Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615. Prettying up comments

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization algorithm to the used model. Furthermore new attribute lists for the different species have been introduced. Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615. Prettying up comments

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization algorithm to the used model. Furthermore new attribute lists for the different species have been introduced. Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615. Prettying up comments

After having rebased on mainline/dev I checked whether all changes made in the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 are active. I also cleaned the code from small errors that occurred due to automatic merging.

…omputationalRadiationPhysics#596,ComputationalRadiationPhysics#607 After the merge of the pull requests ComputationalRadiationPhysics#594, ComputationalRadiationPhysics#596 and ComputationalRadiationPhysics#607 functionality of the ionization feature has been re-established. The example `LWFA_with_Ionization` was reduced to its minimum divergence from the default parameter set.

In this commit the Resolve<> trait from ComputationalRadiationPhysics#594 is used to connect the ionization algorithm to the used model. Furthermore new attribute lists for the different species have been introduced. Functionality still has to be achieved. This has to be checked with ComputationalRadiationPhysics#615. Prettying up comments

psychocoderHPC added 5 commits December 4, 2014 09:28

add trait Resolve

ac749cf

this trait gives the real type of an alias

close ComputationalRadiationPhysics#588, change type alias

d9ada1d

- change `alias` remove inherit - use new trait `Resolve<T>` to handle incomplete types

change documentation, change CMakeLists.txt

eae8b6c

- change documentation of `alias` - remove block of boost 1.56.0+ versions in CMakeLists

remove ThisType from all identifier types

98f6ee7

remove `ThisType` (know available with the trait `Resolve<T>`)

use trait Resolve<T> instead of ::ThisType

72fa606

use new trait `Resolve<T>` to get the type out of an alias

psychocoderHPC added component: PMacc in PMacc component: core in PIConGPU (core application) need-info/blocked labels Dec 4, 2014

psychocoderHPC added this to the Open Beta milestone Dec 4, 2014

psychocoderHPC assigned ax3l Dec 4, 2014

n01r reviewed Dec 4, 2014
View reviewed changes

n01r mentioned this pull request Dec 4, 2014

Ionization in PIConGPU #595

Merged

10 tasks

ax3l removed the need-info/blocked label Dec 5, 2014

ax3l added a commit that referenced this pull request Dec 10, 2014

Merge pull request #594 from psychocoderHPC/topic-cleanAlias

7d44c98

remove `::ThisType` in all identifier types

ax3l merged commit 7d44c98 into ComputationalRadiationPhysics:dev Dec 10, 2014

psychocoderHPC deleted the topic-cleanAlias branch December 10, 2014 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove `::ThisType` in all identifier types #594

remove `::ThisType` in all identifier types #594

psychocoderHPC commented Dec 4, 2014

psychocoderHPC commented Dec 4, 2014

n01r Dec 4, 2014

n01r commented Dec 4, 2014

ax3l commented Dec 8, 2014

psychocoderHPC commented Dec 8, 2014

ax3l commented Dec 8, 2014

n01r commented Dec 9, 2014

ax3l commented Dec 10, 2014

psychocoderHPC commented Dec 10, 2014

n01r commented Dec 10, 2014

psychocoderHPC commented Dec 10, 2014

n01r commented Dec 10, 2014

remove ::ThisType in all identifier types #594

remove ::ThisType in all identifier types #594

Conversation

psychocoderHPC commented Dec 4, 2014

psychocoderHPC commented Dec 4, 2014

n01r Dec 4, 2014

Choose a reason for hiding this comment

n01r commented Dec 4, 2014

ax3l commented Dec 8, 2014

psychocoderHPC commented Dec 8, 2014

ax3l commented Dec 8, 2014

n01r commented Dec 9, 2014

ax3l commented Dec 10, 2014

psychocoderHPC commented Dec 10, 2014

n01r commented Dec 10, 2014

psychocoderHPC commented Dec 10, 2014

n01r commented Dec 10, 2014

remove `::ThisType` in all identifier types #594

remove `::ThisType` in all identifier types #594