Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TBG: Unresolved Variables Warn -> Error #192

Closed
ax3l opened this issue Feb 10, 2014 · 6 comments
Closed

TBG: Unresolved Variables Warn -> Error #192

ax3l opened this issue Feb 10, 2014 · 6 comments
Assignees
@ax3l
Labels
component: tools scripts, python libs and CMake warning code produces/produced a warning
Milestone
0.2.0: Open Beta

Comments

@ax3l
Copy link
Member

ax3l commented Feb 10, 2014

TBG should throw an error and should not submit the job (and should not create a new directory) if it detects unresolved variables.

A warning is not appropriate, since the job won't work at all (see #193).
@ax3l ax3l added this to the Open Beta milestone Feb 10, 2014
@ax3l ax3l added bug labels Feb 10, 2014
ax3l added a commit to ax3l/picongpu that referenced this issue Feb 10, 2014
@ax3l
Fix example cfg files
fd995a3 
related to, but does not solve, ComputationalRadiationPhysics#192
@ax3l ax3l mentioned this issue Feb 10, 2014
Merged
@ax3l ax3l added question and removed bug labels Feb 10, 2014
@psychocoderHPC
Copy link
Member

Yes it produces a warning.

Zeile 44: TBG_movingWindow: Kommando nicht gefunden. 
We reached the maximum substitution loop depth! Possible reasons:
- use of undeclared variables 
- dependency loop with two or more variables WARNING: 1 variable(s) _not_ replaced from template (tpl): !TBG_movingWindow

@PrometheusPi
Copy link
Member

Is it possible to create all simulation directories, etc., throw the error but ignore the submit process in case the "-s" flag was set?
So that everything is created, especially the submit.start file, but can be changed manually later on.

@ax3l
Copy link
Member Author

ax3l commented Feb 11, 2014

Ok, so we create the directory as planned but do not submit the job.

@PrometheusPi
Copy link
Member

👍
If you follow this approach, users would not have to wait till bugs in tbg, *.tplor *.cfg are fixed.

@ax3l
Copy link
Member Author

ax3l commented Feb 11, 2014

Yes, also allows for easier debugging.

ax3l added a commit to ax3l/picongpu that referenced this issue Feb 24, 2014
@ax3l
Close ComputationalRadiationPhysics#192 - Unreplaced Variables Cause …
f5b710c 
…An Error

- change warning to error state
- abort tbg and do not submit malformed job script
@ax3l ax3l assigned ax3l and unassigned psychocoderHPC Feb 24, 2014
@ax3l
Copy link
Member Author

ax3l commented Feb 24, 2014

Closed with #226

@ax3l ax3l closed this as completed Feb 24, 2014
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this issue Aug 6, 2020
@psychocoderHPC
Squashed 'thirdParty/mallocMC/' changes from e2533d141..e444645d0
d87d991 
e444645d0 Merge pull request ComputationalRadiationPhysics#193 from psychocoderHPC/fix-hipclangRuntimeIssue
4875be15d Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/fix-threadFence
fdb48b705 fix clang cuda compile
e99d634c8 fix HIP-clang runtime issues
cb218948b update CONTRIBUTING.md (ComputationalRadiationPhysics#191)
569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces
c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03
cbfa6a2bc fix data races in `Scatter.hpp`
b744e97aa fix data race and printf issue
520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka
136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka
01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e
47b3e4c9b Refactoring (ComputationalRadiationPhysics#181)
25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree
c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate
b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion
97c420697 update gitignore
f658ad286 update evrsion to 2.5.0-crp-dev
9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712
63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree
2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree
f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16
5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport
c3605a691 fix HIP support
31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157)
cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173)
a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch
8dd82718e added 3rd party catch.hpp and made CMake find it
67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka
5dd1d036c switching to C++14
2bb2f3e6d * using alpaka from added git subtree
90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd
ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka'
e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2
28b81447f fix used cmake version
be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0
90d284197 update cmake to 3.15.0
7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format
018543832 added CONTRIBUTING.md with instructions how to use clang-format
4a416a2ec formatting (after clang-tidy)
8aec2cbf3 using trailing return types
5661a80fc formatting
669443d55 * setting column limit and allowing short loops * regrouping includes
edc10db7c added .clang-format file
8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning
95c3223f2 replaced remaining typedefs by using directives
d008ddba6 added .vs and build folders to ignores
5c16da78a applied clang-tidy
6404efdf6 * added a custom target for mallocMC headers * added header files to projects
43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning
28561514d * requiring only C++11 * removed a TODO
507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well
73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again
25e0de345 renamed variables with 2 leading underscores
240d4ea63 Suggested during review
d37e9ed21 addressed review comments
dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost
4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended
e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic
42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85
36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard
d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable
eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute
efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability
450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version
ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability

git-subtree-dir: thirdParty/mallocMC
git-subtree-split: e444645d0e97a5821dcd22a0d3bf3af53e6a0fd9
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this issue Aug 11, 2020
@psychocoderHPC
Squashed 'thirdParty/mallocMC/' changes from e2533d141..e444645d0
ca1820b 
e444645d0 Merge pull request ComputationalRadiationPhysics#193 from psychocoderHPC/fix-hipclangRuntimeIssue
4875be15d Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/fix-threadFence
fdb48b705 fix clang cuda compile
e99d634c8 fix HIP-clang runtime issues
cb218948b update CONTRIBUTING.md (ComputationalRadiationPhysics#191)
569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces
c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03
cbfa6a2bc fix data races in `Scatter.hpp`
b744e97aa fix data race and printf issue
520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka
136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka
01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e
47b3e4c9b Refactoring (ComputationalRadiationPhysics#181)
25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree
c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate
b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion
97c420697 update gitignore
f658ad286 update evrsion to 2.5.0-crp-dev
9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712
63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree
2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree
f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16
5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport
c3605a691 fix HIP support
31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157)
cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173)
a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch
8dd82718e added 3rd party catch.hpp and made CMake find it
67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka
5dd1d036c switching to C++14
2bb2f3e6d * using alpaka from added git subtree
90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd
ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka'
e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2
28b81447f fix used cmake version
be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0
90d284197 update cmake to 3.15.0
7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format
018543832 added CONTRIBUTING.md with instructions how to use clang-format
4a416a2ec formatting (after clang-tidy)
8aec2cbf3 using trailing return types
5661a80fc formatting
669443d55 * setting column limit and allowing short loops * regrouping includes
edc10db7c added .clang-format file
8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning
95c3223f2 replaced remaining typedefs by using directives
d008ddba6 added .vs and build folders to ignores
5c16da78a applied clang-tidy
6404efdf6 * added a custom target for mallocMC headers * added header files to projects
43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning
28561514d * requiring only C++11 * removed a TODO
507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well
73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again
25e0de345 renamed variables with 2 leading underscores
240d4ea63 Suggested during review
d37e9ed21 addressed review comments
dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost
4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended
e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic
42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85
36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard
d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable
eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute
efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability
450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version
ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability

git-subtree-dir: thirdParty/mallocMC
git-subtree-split: e444645d0e97a5821dcd22a0d3bf3af53e6a0fd9
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this issue Nov 27, 2020
@psychocoderHPC
Squashed 'thirdParty/cupla/' changes from abc64f5a9..98dd7f2f6
d218b26 
98dd7f2f6 Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/topic-updateAlpakaTp0.6.0rc3
35e271856 Merge commit 'f29986ae9908b92cce7cfc47d5439c0f1a0a409d' into topic-updateAlpakaTp0.6.0rc3
f29986ae9 Squashed 'alpaka/' changes from 1d921dc064..01f22779da
012980be2 set `CMAKE_MODULE_PATH` for HIP container
e13efa5e0 required interface changes for 0.6.0
33d1b2248 Merge pull request ComputationalRadiationPhysics#188 from sbastrakov/fix-cuplaErrorInvalidDeviceRenaming
70d3f23ef Fix a typo in renaming of cuplaErrorInvalidDevice to CUDA
1922c3c69 Merge pull request ComputationalRadiationPhysics#187 from SimeonEhrig/addAMDCI
ec7f6a764 Update Clang version in gitlab-ci jobs to Clang 11
d0593a9d3 Add hip build to CI

git-subtree-dir: thirdParty/cupla
git-subtree-split: 98dd7f2f648ce02b6ceb9d83289b80997a02d3e2
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this issue Nov 27, 2020
@psychocoderHPC
Squashed 'thirdParty/cupla/' changes from 127f8dcd6..98dd7f2f6
46a4056 
98dd7f2f6 Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/topic-updateAlpakaTp0.6.0rc3
35e271856 Merge commit 'f29986ae9908b92cce7cfc47d5439c0f1a0a409d' into topic-updateAlpakaTp0.6.0rc3
f29986ae9 Squashed 'alpaka/' changes from 1d921dc064..01f22779da
012980be2 set `CMAKE_MODULE_PATH` for HIP container
e13efa5e0 required interface changes for 0.6.0
33d1b2248 Merge pull request ComputationalRadiationPhysics#188 from sbastrakov/fix-cuplaErrorInvalidDeviceRenaming
70d3f23ef Fix a typo in renaming of cuplaErrorInvalidDevice to CUDA
1922c3c69 Merge pull request ComputationalRadiationPhysics#187 from SimeonEhrig/addAMDCI
ec7f6a764 Update Clang version in gitlab-ci jobs to Clang 11
d0593a9d3 Add hip build to CI
abc64f5a9 Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateAlpakaSubtree
73279aa2a Squashed 'alpaka/' changes from 34870a73ec..1d921dc064
1a6fd5c4f Merge commit '73279aa2aab50d3847d4645de4a0e738ae0724f8' into topic-updateAlpakaSubtree
REVERT: 127f8dcd6 Merge commit '6a562a06d49af4b2f0a906d768d7aa78b7e3a4dc' into topic-updateAlpakaSubtree
REVERT: 6a562a06d Squashed 'alpaka/' changes from 34870a73ec..fdb4258283

git-subtree-dir: thirdParty/cupla
git-subtree-split: 98dd7f2f648ce02b6ceb9d83289b80997a02d3e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ax3l ax3l

Labels
component: tools scripts, python libs and CMake warning code produces/produced a warning
Projects
None yet
Milestone
0.2.0: Open Beta
Development

No branches or pull requests
3 participants
@ax3l @psychocoderHPC @PrometheusPi