Fix and unify value types for fields #172
Assignees
Labels
component: core
in PIConGPU (core application)
refactoring
code change to improve performance or to unify a concept but does not change public API
Milestone
Comments
|
Indeed, |
|
I will try to in cooperate a fix for that in #178 |
ax3l
added a commit
to ax3l/picongpu
that referenced
this issue
Feb 7, 2014
promoteType is a type trait, the usual name for their result is not ::ValueType but e.g. ::type or ::result ValueTypes are types of e.g. an internal storage object
|
We should definitely do that. |
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Jun 2, 2020
739236e9b4 creating a single unit test executable if CUDA version is 10.2 or higher 6cc52008a3 moved test main into separate library d15d8b8f54 preventing nvcc from swallowing catch2 header for generating main() fef23d6787 simplified specifying workdivs in 2/3D case b2c6a09b74 removed quotes around compile options 476d08a745 renamed devAllocatorStorage into devAllocatorBuffer, since it's a buffer ec05ebd90a made the AlpakaAcc type a template parameter of DeviceAllocator's and AllocatorHandleImpl's methods instead of the classes themselves bd15540238 * dropped support for HCC * rearranged CUDA_ARCH and HIP macros as requested by psychocoderHPC 4aa77ae193 building tests as well 6e6accef39 fixed printf format specifiers cd97fe83c8 Explicitely specifying return types of alpaka min/max via decltype 15218c0010 * dropped all ReservePoolPolicies * reserving initial memory pool via alpaka buffer (which depends on the device with which the Allocator is constructed) 28f7bddd0d transformed dimensions.cpp tests into Catch2 unit tests a143ca8394 removed example2 from the examples target f0932e8040 * fixed specification of error encountered with alpaka min/max * applying fix only for MSVC 5921f83da4 * changed accelerators in examples and verify_heap_config.hpp back to CUDA * using Malloc<> reserve pool policy everywhere df9ccf0cf9 improved detection for when compiling with HIP device compiler f4b653514a modified tests to also have a grid size greater than 1 d248569246 * fixed remaining atomic intrinsic in XMallocSIMD * properly detecting which GPU backends are available in alpaka * added accelerator name to test output * testing also AccCpuThreads and AccCpuOmp2Threads * added a fix in alpaka to make MSVC compile 96aac162f6 parameterizing tests with accelerator to use 3f1428352e fixed test thread block size and added static check for this f5e90ec4f9 fixed a few warnings 7bfdc48e1c * switching to XMallocSIMD for dimensions tests * added Malloc<Acc> reservePoolPolicy, which uses SimpleCudaMalloc or SimpleMalloc depending on the used accelerator 1ded9068a4 changed alignment policies to work with size_t instead of uint32_t 3f62ab34ca allowing XMallocSIMD to compile without CUDA as well 40ed90e771 fixes for compiling with nvcc again 4b017be62f * buffer Dim does not need to be the same as Acc Dim * handling different dimensions of Acc * added a test executable * added simple test with 1-3D Acc eb21e925f2 * integrated some changes from hipifycation in alpaka * replaced mallocMC CUDA macros by alpaka macros, removed mallocMC_prefixes.hpp * replaced all CUDA kernel invocations by alpaka kernel enqueues * removed all code that targetted CUDA < 9 * merged example02 into example01 since they are almost the same * inlined content of mallocMC_example01_config.hpp * ported kernel invocations to alpaka * replaced cuda allocation routines by alpaka * renamed .cu source files to .cpp * reworked CMakeLists.txt (removed all CUDA stuff, removed big block comments, ...) * added new ReservePoolPolicies SimpleMalloc, intended for running allocator in host memory * passing Alpaka Accelerator through almost all device functions * replaced all atomit operations by alpaka atomics * replaced all CUDA intrinsics by custom implementations in mallocMC_utils.hpp, which default to the intrinsics of the corresponding platform or a default CPU implementation * tried to #ifdef some CUDA thread sync primitives * replaced CUDA thread IDs with alpaka indices and workdivs * replaced __shared__ memory by alpaka shared allocVar * SimpleCudaMalloc and XMallocSIMD are not available, when CUDA is not available, because they are too hard to port for now * refactored thread indexing * incorporating changes from psychocoderHPC from: alpaka-group/mallocMC@dev...psychocoderHPC:topic-hip-port * added a target mallocMCIde to CMakeLists.txt, so developers can browse the code in IDEs * setting compiler warnings via a warnings target, instead of global CMAKE_CXX_FLAGS * setting include directories on targets instead of globally * removed check for CUDA compute capability, since capability 3 is required since CUDA 9 * removed cudaSetDeviceFlags, as it's not needed a2ed3ae927 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e9 added 3rd party catch.hpp and made CMake find it 67bdc1b598 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c4 switching to C++14 2bb2f3e6d9 * using alpaka from added git subtree ea73178789 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' 90bb1ebc63 Squashed 'alpaka/' content from commit a5a8277cd e0be7743ea Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f2 fix used cmake version be77c4c606 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d2841972 update cmake to 3.15.0 7a3d1cebde Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 0185438323 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2eca formatting (after clang-tidy) 8aec2cbf3f using trailing return types 5661a80fc3 formatting 669443d558 * setting column limit and allowing short loops * regrouping includes edc10db7c4 added .clang-format file 8c5a8617d1 Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2c replaced remaining typedefs by using directives d008ddba6b added .vs and build folders to ignores 5c16da78a6 applied clang-tidy 6404efdf61 * added a custom target for mallocMC headers * added header files to projects 43754615dd Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514df * requiring only C++11 * removed a TODO 507111408b a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40d * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de3459 renamed variables with 2 leading underscores 240d4ea634 Suggested during review d37e9ed21e addressed review comments dafc9b7940 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf4 some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd89 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eafb Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0c Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb9 Add a guard around COMPUTE_CAPABILITY cmake variable eff012d664 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5b Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a7 Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e7 Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: 739236e9b44efd810f2eaad0fcf1313222a4d763
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Jun 26, 2020
31f9b3c3f1 version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1e Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae927 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e9 added 3rd party catch.hpp and made CMake find it 67bdc1b598 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c4 switching to C++14 2bb2f3e6d9 * using alpaka from added git subtree ea73178789 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' 90bb1ebc63 Squashed 'alpaka/' content from commit a5a8277cd e0be7743ea Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f2 fix used cmake version be77c4c606 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d2841972 update cmake to 3.15.0 7a3d1cebde Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 0185438323 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2eca formatting (after clang-tidy) 8aec2cbf3f using trailing return types 5661a80fc3 formatting 669443d558 * setting column limit and allowing short loops * regrouping includes edc10db7c4 added .clang-format file 8c5a8617d1 Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2c replaced remaining typedefs by using directives d008ddba6b added .vs and build folders to ignores 5c16da78a6 applied clang-tidy 6404efdf61 * added a custom target for mallocMC headers * added header files to projects 43754615dd Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514df * requiring only C++11 * removed a TODO 507111408b a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40d * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de3459 renamed variables with 2 leading underscores 240d4ea634 Suggested during review d37e9ed21e addressed review comments dafc9b7940 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf4 some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd89 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eafb Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0c Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb9 Add a guard around COMPUTE_CAPABILITY cmake variable eff012d664 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5b Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a7 Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e7 Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: 31f9b3c3f1cf919a96312a30ab9aa223f41fed67
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Jul 27, 2020
2f692582a Merge pull request ComputationalRadiationPhysics#184 from psychocoderHPC/topic-updateToLatestAlpaka 7cde71357 Merge commit 'ff8c0b6ffa6f27e83ad092c435563137a85a8bd3' into topic-updateToLatestAlpaka ff8c0b6ff Squashed 'alpaka/' changes from 79ca8bbb00..34870a73ec 46ebaf3e8 fix multi GPU streams handling and default stream ac24b2e0d Merge pull request ComputationalRadiationPhysics#180 from psychocoderHPC/topic-versionIncreaseTo0.3.0 f2cd8e551 Merge pull request ComputationalRadiationPhysics#181 from psychocoderHPC/topic-updateToAlpaka0.5.0 3c8499375 Squashed 'alpaka/' changes from c2d14d09ea..79ca8bbb00 046a8a0e7 Merge commit '3c8499375f5d60084cf8ef055851e6c78369a142' into topic-updateToAlpaka0.5.0 60f3b604f Merge pull request ComputationalRadiationPhysics#179 from psychocoderHPC/fix-requiredCuplaRenamingHeadersForCOnfigHeaders 9593e54c8 increase version to 0.3.0 1242fb832 config headers: no not require cupla renaming headers 69f83971f Merge pull request ComputationalRadiationPhysics#177 from SimeonEhrig/multiVersionCI2 3dafd43ee GitLab-CI: extended to iterate over different versions 0a6656449 Merge pull request ComputationalRadiationPhysics#176 from psychocoderHPC/topic-wrongMasterToDevPort 55d44aa5f Fixed URLs in INSTALL.md 50967c83e Refactor GitLab CI 7e7509463 Merge pull request ComputationalRadiationPhysics#172 from jkelling/fixSemiWarnings 2870f63f4 Rm superfluous ; git-subtree-dir: thirdParty/cupla git-subtree-split: 2f692582adf3f23bb8d8b6730de355b39fc25c4f
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Jul 30, 2020
569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: 569313f1adb06ed2a221a975e7d909e4bcef6339
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Jul 30, 2020
849738bd7 Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateGitIrgnore 42fb4bddc update gitignore 2f692582a Merge pull request ComputationalRadiationPhysics#184 from psychocoderHPC/topic-updateToLatestAlpaka 7cde71357 Merge commit 'ff8c0b6ffa6f27e83ad092c435563137a85a8bd3' into topic-updateToLatestAlpaka ff8c0b6ff Squashed 'alpaka/' changes from 79ca8bbb00..34870a73ec 46ebaf3e8 fix multi GPU streams handling and default stream ac24b2e0d Merge pull request ComputationalRadiationPhysics#180 from psychocoderHPC/topic-versionIncreaseTo0.3.0 f2cd8e551 Merge pull request ComputationalRadiationPhysics#181 from psychocoderHPC/topic-updateToAlpaka0.5.0 3c8499375 Squashed 'alpaka/' changes from c2d14d09ea..79ca8bbb00 046a8a0e7 Merge commit '3c8499375f5d60084cf8ef055851e6c78369a142' into topic-updateToAlpaka0.5.0 60f3b604f Merge pull request ComputationalRadiationPhysics#179 from psychocoderHPC/fix-requiredCuplaRenamingHeadersForCOnfigHeaders 9593e54c8 increase version to 0.3.0 1242fb832 config headers: no not require cupla renaming headers 69f83971f Merge pull request ComputationalRadiationPhysics#177 from SimeonEhrig/multiVersionCI2 3dafd43ee GitLab-CI: extended to iterate over different versions 0a6656449 Merge pull request ComputationalRadiationPhysics#176 from psychocoderHPC/topic-wrongMasterToDevPort 55d44aa5f Fixed URLs in INSTALL.md 50967c83e Refactor GitLab CI 7e7509463 Merge pull request ComputationalRadiationPhysics#172 from jkelling/fixSemiWarnings 2870f63f4 Rm superfluous ; git-subtree-dir: thirdParty/cupla git-subtree-split: 849738bd7c83615d161119b9b4b8616c91c6b6d6
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Jul 30, 2020
569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: 569313f1adb06ed2a221a975e7d909e4bcef6339
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Aug 6, 2020
e444645d0 Merge pull request ComputationalRadiationPhysics#193 from psychocoderHPC/fix-hipclangRuntimeIssue 4875be15d Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/fix-threadFence fdb48b705 fix clang cuda compile e99d634c8 fix HIP-clang runtime issues cb218948b update CONTRIBUTING.md (ComputationalRadiationPhysics#191) 569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: e444645d0e97a5821dcd22a0d3bf3af53e6a0fd9
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Aug 6, 2020
127f8dcd6 Merge commit '6a562a06d49af4b2f0a906d768d7aa78b7e3a4dc' into topic-updateAlpakaSubtree 6a562a06d Squashed 'alpaka/' changes from 34870a73ec..fdb4258283 849738bd7 Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateGitIrgnore 42fb4bddc update gitignore 2f692582a Merge pull request ComputationalRadiationPhysics#184 from psychocoderHPC/topic-updateToLatestAlpaka ff8c0b6ff Squashed 'alpaka/' changes from 79ca8bbb00..34870a73ec 7cde71357 Merge commit 'ff8c0b6ffa6f27e83ad092c435563137a85a8bd3' into topic-updateToLatestAlpaka 46ebaf3e8 fix multi GPU streams handling and default stream ac24b2e0d Merge pull request ComputationalRadiationPhysics#180 from psychocoderHPC/topic-versionIncreaseTo0.3.0 f2cd8e551 Merge pull request ComputationalRadiationPhysics#181 from psychocoderHPC/topic-updateToAlpaka0.5.0 3c8499375 Squashed 'alpaka/' changes from c2d14d09ea..79ca8bbb00 046a8a0e7 Merge commit '3c8499375f5d60084cf8ef055851e6c78369a142' into topic-updateToAlpaka0.5.0 60f3b604f Merge pull request ComputationalRadiationPhysics#179 from psychocoderHPC/fix-requiredCuplaRenamingHeadersForCOnfigHeaders 9593e54c8 increase version to 0.3.0 1242fb832 config headers: no not require cupla renaming headers 69f83971f Merge pull request ComputationalRadiationPhysics#177 from SimeonEhrig/multiVersionCI2 3dafd43ee GitLab-CI: extended to iterate over different versions 0a6656449 Merge pull request ComputationalRadiationPhysics#176 from psychocoderHPC/topic-wrongMasterToDevPort 55d44aa5f Fixed URLs in INSTALL.md 50967c83e Refactor GitLab CI 7e7509463 Merge pull request ComputationalRadiationPhysics#172 from jkelling/fixSemiWarnings 2870f63f4 Rm superfluous ; git-subtree-dir: thirdParty/cupla git-subtree-split: 127f8dcd6946fa575500f7ceec7077b265f5cdc7
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Aug 10, 2020
abc64f5a9 Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateAlpakaSubtree 1a6fd5c4f Merge commit '73279aa2aab50d3847d4645de4a0e738ae0724f8' into topic-updateAlpakaSubtree 73279aa2a Squashed 'alpaka/' changes from 34870a73ec..1d921dc064 849738bd7 Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateGitIrgnore 42fb4bddc update gitignore 2f692582a Merge pull request ComputationalRadiationPhysics#184 from psychocoderHPC/topic-updateToLatestAlpaka ff8c0b6ff Squashed 'alpaka/' changes from 79ca8bbb00..34870a73ec 7cde71357 Merge commit 'ff8c0b6ffa6f27e83ad092c435563137a85a8bd3' into topic-updateToLatestAlpaka 46ebaf3e8 fix multi GPU streams handling and default stream ac24b2e0d Merge pull request ComputationalRadiationPhysics#180 from psychocoderHPC/topic-versionIncreaseTo0.3.0 f2cd8e551 Merge pull request ComputationalRadiationPhysics#181 from psychocoderHPC/topic-updateToAlpaka0.5.0 3c8499375 Squashed 'alpaka/' changes from c2d14d09ea..79ca8bbb00 046a8a0e7 Merge commit '3c8499375f5d60084cf8ef055851e6c78369a142' into topic-updateToAlpaka0.5.0 60f3b604f Merge pull request ComputationalRadiationPhysics#179 from psychocoderHPC/fix-requiredCuplaRenamingHeadersForCOnfigHeaders 9593e54c8 increase version to 0.3.0 1242fb832 config headers: no not require cupla renaming headers 69f83971f Merge pull request ComputationalRadiationPhysics#177 from SimeonEhrig/multiVersionCI2 3dafd43ee GitLab-CI: extended to iterate over different versions 0a6656449 Merge pull request ComputationalRadiationPhysics#176 from psychocoderHPC/topic-wrongMasterToDevPort 55d44aa5f Fixed URLs in INSTALL.md 50967c83e Refactor GitLab CI 7e7509463 Merge pull request ComputationalRadiationPhysics#172 from jkelling/fixSemiWarnings 2870f63f4 Rm superfluous ; git-subtree-dir: thirdParty/cupla git-subtree-split: abc64f5a9852d0d7e389b9a5f4b988df70af1123
psychocoderHPC
pushed a commit
to psychocoderHPC/picongpu
that referenced
this issue
Aug 11, 2020
e444645d0 Merge pull request ComputationalRadiationPhysics#193 from psychocoderHPC/fix-hipclangRuntimeIssue 4875be15d Merge pull request ComputationalRadiationPhysics#192 from psychocoderHPC/fix-threadFence fdb48b705 fix clang cuda compile e99d634c8 fix HIP-clang runtime issues cb218948b update CONTRIBUTING.md (ComputationalRadiationPhysics#191) 569313f1a Merge pull request ComputationalRadiationPhysics#190 from psychocoderHPC/fix-dataRaces c2505573d Merge pull request ComputationalRadiationPhysics#189 from psychocoderHPC/fix-mallocMCExample03 cbfa6a2bc fix data races in `Scatter.hpp` b744e97aa fix data race and printf issue 520441e5b Merge pull request ComputationalRadiationPhysics#188 from psychocoderHPC/topic-updateAlpaka 136f73013 Merge commit '01e9abcfa60f1a5c9a1373321e9286374c57027c' into topic-updateAlpaka 01e9abcfa Squashed 'alpaka/' changes from 3e8567126..34870a73e 47b3e4c9b Refactoring (ComputationalRadiationPhysics#181) 25076a35d Merge pull request ComputationalRadiationPhysics#185 from psychocoderHPC/topic-updateAlpakaSubtree c1e596b3f Merge pull request ComputationalRadiationPhysics#187 from psychocoderHPC/topic-gitIgnoreUpdate b7aac310d Merge pull request ComputationalRadiationPhysics#186 from psychocoderHPC/topic-updateDevVersion 97c420697 update gitignore f658ad286 update evrsion to 2.5.0-crp-dev 9d6e21640 Squashed 'alpaka/' changes from b2a80b16..3e856712 63e5a3762 Merge commit '9d6e216402149143b07efe610265a171fe7ed062' into topic-updateAlpakaSubtree 2dc0bef38 Merge commit 'f2a664bcc2f3a201a309e48f3e0ced11e1a0667e' into topic-updateAlpakaSubtree f2a664bcc Squashed 'alpaka/' changes from a5a8277c..b2a80b16 5bced863b Merge pull request ComputationalRadiationPhysics#182 from psychocoderHPC/fix-HIPSupport c3605a691 fix HIP support 31f9b3c3f version update 2.4.0crp and changelog (ComputationalRadiationPhysics#157) cc54375b1 Port to alpaka (ComputationalRadiationPhysics#173) a2ed3ae92 Merge pull request ComputationalRadiationPhysics#179 from bernhardmgruber/catch 8dd82718e added 3rd party catch.hpp and made CMake find it 67bdc1b59 Merge pull request ComputationalRadiationPhysics#176 from bernhardmgruber/addAlpaka 5dd1d036c switching to C++14 2bb2f3e6d * using alpaka from added git subtree 90bb1ebc6 Squashed 'alpaka/' content from commit a5a8277cd ea7317878 Merge commit '90bb1ebc63d8281718381494e1d91733ac79c405' as 'alpaka' e0be7743e Merge pull request ComputationalRadiationPhysics#178 from psychocoderHPC/fix-travisCmakeUsage2 28b81447f fix used cmake version be77c4c60 Merge pull request ComputationalRadiationPhysics#174 from psychocoderHPC/topic-updateCmakeTo3.15.0 90d284197 update cmake to 3.15.0 7a3d1cebd Merge pull request ComputationalRadiationPhysics#172 from bernhardmgruber/format 018543832 added CONTRIBUTING.md with instructions how to use clang-format 4a416a2ec formatting (after clang-tidy) 8aec2cbf3 using trailing return types 5661a80fc formatting 669443d55 * setting column limit and allowing short loops * regrouping includes edc10db7c added .clang-format file 8c5a8617d Merge pull request ComputationalRadiationPhysics#171 from bernhardmgruber/cleaning 95c3223f2 replaced remaining typedefs by using directives d008ddba6 added .vs and build folders to ignores 5c16da78a applied clang-tidy 6404efdf6 * added a custom target for mallocMC headers * added header files to projects 43754615d Merge pull request ComputationalRadiationPhysics#169 from bernhardmgruber/cleaning 28561514d * requiring only C++11 * removed a TODO 507111408 a little modernization of the CMakeLists * using CUDA via project language instead of deprecated find_package * setting CUDA standard to have C++14 inside CUDA as well 73e21de40 * removed check that pagesize is unsigned * made pagesizes signed literals again 25e0de345 renamed variables with 2 leading underscores 240d4ea63 Suggested during review d37e9ed21 addressed review comments dafc9b794 * replaced usage of boost::mpl by static constexpr members * dropped dependency on boost 4962156bf some cleanup * requiring C++14 * using cstdint instead of boost/cstdint.hpp * using std::tuple instead of boost::tuple * using nullptr * using static_assert * using constexpr * adding const and static where appropriate * removed a few empty lines * replaced std::endl by \n where flush was probably not intended e383f3cd8 Merge pull request ComputationalRadiationPhysics#170 from ax3l/topic-ciBionic 42aed7eaf Travis CI: GCC 5.5.0 + CUDA 9.1.85 36cb7f9f0 Merge pull request ComputationalRadiationPhysics#165 from sbastrakov/topic-nvccComputeCapabilityGuard d911d0cbb Add a guard around COMPUTE_CAPABILITY cmake variable eff012d66 Merge pull request ComputationalRadiationPhysics#161 from sbastrakov/topic-cudaDeviceGetArrribute efd20bce5 Merge pull request ComputationalRadiationPhysics#164 from sbastrakov/fix-nvccComputeCapability 450c73d3a Choose the value for the -arch nvcc flag depending on CUDA version ce377f18e Use cudaDeviceGetAttribute() for querying the compute capability git-subtree-dir: thirdParty/mallocMC git-subtree-split: e444645d0e97a5821dcd22a0d3bf3af53e6a0fd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, fields have different ways to access their basic value type.
FieldTmpcan be asked for its::ValueType. Other fields, e.g.FieldB, do not have such a typedef. Hence their type must be known to be hardfloat.There should be a single, reliable method to obtain this type which uses type traits.
The text was updated successfully, but these errors were encountered: