Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fixed a bug where MarkdownTextBlock loses all events after … #3180

Merged
merged 4 commits into from
Mar 31, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ private void RenderMarkdown()
// Disconnect from OnClick handlers.
UnhookListeners();

// Clear everything that exists.
_listeningHyperlinks.Clear();

var markdownRenderedArgs = new MarkdownRenderedEventArgs(null);

// Make sure we have something to parse.
Expand Down Expand Up @@ -174,9 +177,25 @@ private void RenderMarkdown()
MarkdownRendered?.Invoke(this, markdownRenderedArgs);
}

private void HookListeners()
{
// Re-hook all hyper link events we currently have
foreach (object link in _listeningHyperlinks)
{
if (link is Hyperlink hyperlink)
{
hyperlink.Click += Hyperlink_Click;
}
else if (link is Image image)
{
image.Tapped += NewImagelink_Tapped;
}
}
}

private void UnhookListeners()
{
// Clear any hyper link events if we have any
// Unhook any hyper link events if we have any
foreach (object link in _listeningHyperlinks)
{
if (link is Hyperlink hyperlink)
Expand All @@ -188,9 +207,6 @@ private void UnhookListeners()
image.Tapped -= NewImagelink_Tapped;
}
}

// Clear everything that exists.
_listeningHyperlinks.Clear();
}

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ private void ThemeListener_ThemeChanged(Helpers.ThemeListener sender)
private void OnLoaded(object sender, RoutedEventArgs e)
{
RegisterThemeChangedHandler();
HookListeners();

// Register for property callbacks that are owned by our parent class.
_fontSizePropertyToken = RegisterPropertyChangedCallback(FontSizeProperty, OnPropertyChanged);
Expand Down