[Bug fix] Fixed a bug where MarkdownTextBlock loses all events after … #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-load [Bug fix] Fixed a bug where MarkdownTextBlock loses all events after re-load. Issue is described here: 0x7c13/Notepads#377
|
Thanks JasonStein for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
@michael-hawker I accidentally closed it, can you help re-open this PR again? Thanks! |
vgromfeld
approved these changes
Mar 23, 2020
azchohfi
previously requested changes
Mar 24, 2020
Microsoft.Toolkit.Uwp.UI.Controls/MarkdownTextBlock/MarkdownTextBlock.Methods.cs
Show resolved
Hide resolved
Unhook event before assigning to make sure no duplicate
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
|
Should be ready to go, any comments guys? |
michael-hawker
approved these changes
Mar 31, 2020
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixed a bug where MarkdownTextBlock loses all events after page re-load. Issue is described here: 0x7c13/Notepads#377
The root cause here is that we should not clear all existing events onUnloaded since page might be reloaded in the future since Unloaded != Dispose. Instead of unhook events and clear references, we should just unhook the events during page unload and re-hook everything back if it reloads. Since we have all the events already unhooked in Unload event, we should expect GC to kicks in at certain point if MarkdownTextBlock never reload again in the future. So we are fine of keeping the event references here.
PR Type
Bugfix
What is the current behavior?
MarkdownTextBlock loses all events after re-load.
What is the new behavior?
MarkdownTextBlock should keep all existing events after page re-load.
PR Checklist
Please check if your PR fulfills the following requirements: