Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump to Uno 5.x #157

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

MartinZikmund
Copy link
Contributor

@MartinZikmund MartinZikmund commented Nov 24, 2023

Related to CommunityToolkit/Windows#281

Bump Uno Platform target version to 5.0.48

@giraudremy
Copy link

giraudremy commented Nov 24, 2023

I have similar issue with v8.0 : System.MissingMethodException: Method not found: double Microsoft.UI.Xaml.Thickness.get_Left()
CommunityToolkit/Windows#278

@MartinZikmund
Copy link
Contributor Author

I have similar issue with v8.0 : System.MissingMethodException: Method not found: double Microsoft.UI.Xaml.Thickness.get_Left()
https://github.com/CommunityToolkit/Windows/discussions/278

Should fix that as well

@michael-hawker
Copy link
Member

@MartinZikmund is there a way to fix this for both Uno 4.x and 5.x users instead?

Or are you seeing most Uno 4.x folks upgrade to 5 right away? Just concerned with forcing folks to have to update when taking toolkit packages.

Looks like there's more beyond just a version bump that's needed here too. 😅

@MartinZikmund
Copy link
Contributor Author

MartinZikmund commented Nov 28, 2023

I think it is safe to upgrade as most people upgrade right away (as there is a lot of new features), plus all the first party libraries are updated to 5.x right away too, so if you want to use the latest of anything, then updating to 5.x and later is the only option.

Will check for the failures though!

@michael-hawker
Copy link
Member

@MartinZikmund you still planning to take a look at the failures or need assistance? We're tentatively hoping to do an update in a couple weeks once we resolve some other issues as well, so we could work this one in.

@MartinZikmund
Copy link
Contributor Author

@michael-hawker can you please run the workflows again? I rebased and didn't realize I would not see the build failures then anymore :-( ...

@michael-hawker
Copy link
Member

@MartinZikmund no worries, rekicked, though if you go to the main Actions tab you should be able to find the old build, think this was it:
https://github.com/CommunityToolkit/Tooling-Windows-Submodule/actions/runs/7022761057

@MartinZikmund
Copy link
Contributor Author

Created unoplatform/uno#14759 which should fix the build issue, will rebase on that update of Uno after it is merged

@MartinZikmund
Copy link
Contributor Author

@michael-hawker let's try again now 🚀

@MartinZikmund
Copy link
Contributor Author

Still the same, trying the latest to see whether the backport was not successful somehow, can you please run the workflow?

@MartinZikmund MartinZikmund changed the title feat: Bump to Uno 5.0.48 feat: Bump to Uno 5.x Dec 19, 2023
Includes a fix for a XAML code generation issue related to x:Bind to events (see unoplatform/uno#14737)
@MartinZikmund
Copy link
Contributor Author

@Arlodotexe let's try again

@Arlodotexe
Copy link
Member

@MartinZikmund The CI is passing for the submodule, but when building the Wasm head in the CommunityToolkit/Windows or CommunityToolkit/Labs-Windows repo, I'm getting errors such as

CSC : error UXAML0001: The type x:String could not be found [D:\source\uwp\lib\Windows\components\Converters\sam
       ples\Converters.Samples.csproj::TargetFramework=net7.0]

I've opened a PR here so we can see the errors coming from toolkit components in the CI.

This version re-adds VectorExtensions which are used by Toolkit
Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Jan 10, 2024
Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Jan 19, 2024
@MartinZikmund
Copy link
Contributor Author

@Arlodotexe new update is in, now including the unoplatform/uno#15155 fix

@michael-hawker
Copy link
Member

Thanks @MartinZikmund, I kicked off the CI. @Arlodotexe you going to update the dependent PR on the main repo?

Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Jan 23, 2024
Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Jan 24, 2024
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green in CommunityToolkit/Windows#311, let's merge

@Arlodotexe Arlodotexe merged commit 5a91d82 into CommunityToolkit:main Jan 24, 2024
8 checks passed
Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants