-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump to Uno 5.x #157
feat: Bump to Uno 5.x #157
Conversation
I have similar issue with v8.0 : System.MissingMethodException: Method not found: double Microsoft.UI.Xaml.Thickness.get_Left() |
Should fix that as well |
@MartinZikmund is there a way to fix this for both Uno 4.x and 5.x users instead? Or are you seeing most Uno 4.x folks upgrade to 5 right away? Just concerned with forcing folks to have to update when taking toolkit packages. Looks like there's more beyond just a version bump that's needed here too. 😅 |
I think it is safe to upgrade as most people upgrade right away (as there is a lot of new features), plus all the first party libraries are updated to 5.x right away too, so if you want to use the latest of anything, then updating to 5.x and later is the only option. Will check for the failures though! |
@MartinZikmund you still planning to take a look at the failures or need assistance? We're tentatively hoping to do an update in a couple weeks once we resolve some other issues as well, so we could work this one in. |
10c483f
to
c753148
Compare
@michael-hawker can you please run the workflows again? I rebased and didn't realize I would not see the build failures then anymore :-( ... |
@MartinZikmund no worries, rekicked, though if you go to the main Actions tab you should be able to find the old build, think this was it: |
Created unoplatform/uno#14759 which should fix the build issue, will rebase on that update of Uno after it is merged |
@michael-hawker let's try again now 🚀 |
Still the same, trying the latest to see whether the backport was not successful somehow, can you please run the workflow? |
Includes a fix for a XAML code generation issue related to x:Bind to events (see unoplatform/uno#14737)
9f010f5
to
f1f3961
Compare
@Arlodotexe let's try again |
@MartinZikmund The CI is passing for the submodule, but when building the Wasm head in the
I've opened a PR here so we can see the errors coming from toolkit components in the CI. |
This version re-adds VectorExtensions which are used by Toolkit
b55c137
to
2a342bd
Compare
@Arlodotexe new update is in, now including the unoplatform/uno#15155 fix |
Thanks @MartinZikmund, I kicked off the CI. @Arlodotexe you going to update the dependent PR on the main repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green in CommunityToolkit/Windows#311, let's merge
Related to CommunityToolkit/Windows#281
Bump Uno Platform target version to 5.0.48