-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x:Bind to event in ResourceDictionary
#14737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we were propagating FindName to the Content view, even if it was "overriden" by the ContentTemplate, which then could result in StackOverflow
github-actions
bot
added
area/code-generation
Categorizes an issue or PR as relevant to code generation
area/automation
Categorizes an issue or PR as relevant to project automation
labels
Dec 6, 2023
🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14737/index.html |
🤖 Your docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-14737/index.html |
@Mergifyio backport release/stable/5.0 |
✅ Backports have been created
|
ajpinedam
approved these changes
Dec 9, 2023
jeromelaban
added a commit
that referenced
this pull request
Dec 11, 2023
…5.0/pr-14737 x:Bind to event in `ResourceDictionary` (backport #14737)
MartinZikmund
added a commit
to MartinZikmund/Tooling-Windows-Submodule
that referenced
this pull request
Dec 18, 2023
This fixes a XAML code generation issue related to x:Bind to events (see unoplatform/uno#14737)
MartinZikmund
added a commit
to MartinZikmund/Tooling-Windows-Submodule
that referenced
this pull request
Dec 19, 2023
Includes a fix for a XAML code generation issue related to x:Bind to events (see unoplatform/uno#14737)
Arlodotexe
pushed a commit
to CommunityToolkit/Tooling-Windows-Submodule
that referenced
this pull request
Jan 24, 2024
Includes a fix for a XAML code generation issue related to x:Bind to events (see unoplatform/uno#14737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/automation
Categorizes an issue or PR as relevant to project automation
area/code-generation
Categorizes an issue or PR as relevant to code generation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #13550, closes #14286
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):