Added manually defined required compilations constants #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…munityToolkit/Labs-Windows into fix/compilation-conditionals
…munityToolkit/Labs-Windows into fix/compilation-conditionals
…munityToolkit/Labs-Windows into fix/compilation-conditionals
template/lab/samples/ProjectTemplate.Wasm/ProjectTemplate.Wasm.csproj
Outdated
Show resolved
Hide resolved
labs/CanvasLayout/samples/CanvasLayout.Wasm/CanvasLayout.Wasm.csproj
Outdated
Show resolved
Hide resolved
michael-hawker
approved these changes
Jul 20, 2022
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…kit#208) * Moved project identifiers into a new props file * Moved project identifiers into a new props file * Merge branch 'fix/compilation-conditionals' of https://github.com/CommunityToolkit/Labs-Windows into fix/compilation-conditionals * Added WINUI2 and WINUI3 compilation conditionals * Added platform-specific compilation conditionals * Added comment for props modified by script * Added __SKIA__ compilation conditional * Added Labs.ProjectIdentifiers.props import * Fixed ProjectIdentifiers on project heads * Fixed incorrect IsUno value * Fixed BindableMetadataProvider error on WPF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labs.PlatformIdentifiers.propsWINUI2andWINUI3as compilation constants, to supplement (and eventually phase out) the potentially confusingWINAPPSDKcompilation constant which is only available when using WINUI 3, even under Uno.WINDOWS_UWP,NETFX_CORE,WINDOWS_WINAPPSDK,__WASM__,HAS_UNO_WASM,__ANDROID__,__IOS__,__MACOS__,HAS_UNO_SKIA,__SKIA__,WINDOWS_WPF, and__GTK__.