-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 [Experiment] SizerBase class for GridSplitter + ContentSizer + PropertySizer #101
Comments
Couple of things I've noticed, looks like I broke the WASM hover implementation again... and we should investigate an auto-collapse behavior mode too. |
Figured out what was going on with the cursor not properly updating when the Orientation is Horizontal (like in the sample) - regression from current Toolkit version. It's this code here: Labs-Windows/labs/SizerBase/src/SizerBase.Properties.cs Lines 98 to 110 in 9045236
Since we set the value of the dependency property, when the initial pass run on load sets it to Think this was abstracted in the old code as the inner class held that info. Here, I think we need to just have the private value tracking what the cursor should be and leave the Cursor property for overrides? Will think about it more and get back to it as a separate fix. Effects UWP and WASM (basically WinUI 2), Windows App SDK uses a different setup, so I think is uneffected. |
Behavior for WindowsAppSDK is looking good now on 1.3, will push a PR up shortly, also trying to fix the Cursor orientation bug number #388. |
@alexfalconflores are you using the new package ( |
@alexfalconflores Looks like you are using the So, instead of using CommunityToolkit.Labs.Uwp.Sizers use the CommunityToolkit.Uwp.Sizers package.. it's on the same preview Nuget feed! |
Thanks for the help @niels9001 and @michael-hawker. The new control design looks great. Keep it up. Do you know when UWP will support .net 7 or 8? CommunityToolkit.Uwp.Controls.Sizers . nuget prerelease |
@alexfalconflores see discussions here and here - if you need the latest .NET then you'd want to port to WinUI 3 (which is what we're making all our components work with both to make it easy to do). If you just need newer language features for C#, look at PolySharp. |
This was shipped in the 8.0 Release, please update to use that version of the component. Any further issues/requests should start in the main repository. |
So I always have to point the cursor to the center of that splitter despite it requires the whole space along the container? And the normal GridSplitter belongs to a deprecated package, but has no hover function, sigh, WinUI has become a mess. |
@Fabi12345 This issue is closed, so it might not reflect the latest changes.
Recording.2024-10-24.160306.mp4
You can install the Windows Community Gallery app from the Store here, it has all of the information you'd need: https://www.microsoft.com/store/productId/9NBLGGH4TLCQ |
Oh ok, that looks better, gonna try it, thanks! |
Approved from Discussion #96
Problem Statement (copied from Discussion):
We have various types of experience which need 'gripper bars' in order to provide a user with the ability to resize/drag an area of UI around in an application. These all have similar visual and behavior cues, but may require different logic to manipulate the underlying UI structure.
Overview
This experiment adds the following components:
Grid
's rows/columnsWidth
/Height
of anyFrameworkElement
double
valueUsing
You can try it out via the NuGet Packages here:
Read more about Preview Packages here.
This control has moved from Labs to the new main repo.
CommunityToolkit members can also try it out with Codespaces.
TO DO
Not all these items are required to submit a PR. This list is here to help track what is remaining to implement before a technical review and discussion of moving into the main repository can occur.
Implementation Requirements
Tested Platforms
These items can sometimes be done ahead of time, but are usually started and completed after all implementation details are finished.
Technical Review
The text was updated successfully, but these errors were encountered: