Prometheus persist: Programatically adds a docker volume on to the docker-compose to be used for storing prometheus data #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
795d010 to
2b0fb27
Compare
…o be used for storing prometheus data
2b0fb27 to
6236074
Compare
|
made some adjustments as discussed. The prometheus data dir is now using a docker volume, as it avoids requiring the user to set up permissions for the folder. If the user needs to specify a different directory , then it's likely they have a different instance of prometheus running. In the future we could consider adding a "clean" command that removes all data created by commit boost, including the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programatically add a docker volume to the docker-compose to be used for storing prometheus data