Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist prometheus storage #24

Closed
ltitanb opened this issue Jul 16, 2024 · 2 comments
Closed

Persist prometheus storage #24

ltitanb opened this issue Jul 16, 2024 · 2 comments
Assignees
Labels
observability Metrics, logging, dashboards

Comments

@ltitanb
Copy link
Collaborator

ltitanb commented Jul 16, 2024

All the prometheus metrics are currently wiped when restarting commit boost. We should have the option to persist those to disk

@ltitanb ltitanb added enhancement observability Metrics, logging, dashboards labels Jul 16, 2024
@aimxhaisse
Copy link
Contributor

Retention of metrics is usually handled by prometheus itself and commit-boost should probably start with no context/be stateless.

The usual way is to write prometheus queries around this to handle restarts, for example: if you want total queries done to relayers in the last 3 days and you only have a counter that is initialized at 0 at startup and commit-boost restarts 5 times, it's totally fine, you can do a sum(metric...) in prom ; in general better be stupid around metrics and work around them using promql.

This approach is handy especially if you work at scale: chances are you'll have N replicas of commit-boost that can all receive queries (to have HA, be able to upgrade commit-boost without missing blocks, etc), so each commit-boost is independent and has its own metrics and via PromQL you can still craft queries to have the global view.

@ltitanb
Copy link
Collaborator Author

ltitanb commented Aug 2, 2024

closed by #49

@ltitanb ltitanb closed this as completed Aug 2, 2024
@ltitanb ltitanb mentioned this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
observability Metrics, logging, dashboards
Projects
None yet
Development

No branches or pull requests

3 participants