Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Collaborator Handle + Add Notification Email #39

Merged
merged 14 commits into from
Jul 31, 2024

Conversation

chrisdedman
Copy link
Contributor

@chrisdedman chrisdedman commented Jul 19, 2024

The PR adds the functionality to send a notification email to a collaborator that has just been added to a notebook. This feature allows users to add others to collaborate on a notebook.

This PR also includes the following:

  • Update the collaborator field to implement the frontend feature where the user will use the user email address rather than the user ID (which makes more sense that way too).
  • Update owner_type that causes an error when trying to fetch notebook owner. the owner_type was an uppercase User instead of a lowercase user.

This PR is a blocker for the frontend, thus need to be merged prior the following:

The code changes in this commit add the functionality to send an invitation email to a collaborator. This feature allows users to invite others to collaborate on a notebook. The `send_invite/2` function is implemented in the `Cursif.Notebooks` module, which sends an email to the specified collaborator for the given notebook.
The code changes in this commit add the functionality to send an invitation email to a collaborator when adding them to a notebook. This feature allows users to invite others to collaborate on a notebook. The `send_invite/2` function is implemented in the `Cursif.Notebooks` module, which sends an email to the specified collaborator for the given notebook.
This commit adds a new email template, "invite.html.eex", which is used to send collaboration invitation emails to users. The template includes a header, content section with a personalized message, and a button to join the notebook. It also includes a message signature and email signature at the end. This template will be used when inviting collaborators to join a notebook on Cursif.
@chrisdedman chrisdedman changed the title Updated Collaborator Handle Updated Collaborator Handle + Invitation Email Jul 20, 2024
@chrisdedman chrisdedman added the enhancement New feature or request label Jul 20, 2024
This commit updates the collaboration email functionality in the `Cursif` application. It renames the `send_collaborator_invitation_email` function to `send_collaborator_email` in the `CursifWeb.Emails.UserEmail` module. Additionally, it updates the email template from "invite.html.eex" to "add.html.eex" and modifies the email subject from "Cursif ~ Collaboration Invitation" to "Cursif ~ Collaboration Notification". These changes improve the clarity and consistency of the collaboration email feature.
@chrisdedman chrisdedman changed the title Updated Collaborator Handle + Invitation Email Updated Collaborator Handle + Add Collab Email Jul 20, 2024
@chrisdedman chrisdedman changed the title Updated Collaborator Handle + Add Collab Email Updated Collaborator Handle + Add Notification Email Jul 20, 2024
@PenguinBoi12 PenguinBoi12 merged commit 256055c into main Jul 31, 2024
2 checks passed
@chrisdedman chrisdedman deleted the collab-update branch August 9, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants