Introduce Source::Metadata #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2016
| end | ||
|
|
||
| def path_fragment(pod_name, version = nil) | ||
| prefixes = if prefix_lengths.empty? |
There was a problem hiding this comment.
I think this would be a little cleaner if the if/else were a separate method?
|
|
||
| # @return [Array<Source>] The list of the sources with the given names. | ||
| # | ||
| # @param [Array<#to_s>] names |
There was a problem hiding this comment.
is this correct? [Array<#to_s>] - don't think I've seen it before :)
There was a problem hiding this comment.
yeah -- it means an array of stuff that responds to to_s
|
LGTM 👍 |
This also allows for specs directory sharding
762fc36 to
b6df430
Compare
|
This is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing so, we've migrated
Pod::SourcesManagerfrom CocoaPods/CocoaPods as a singleton to be a proper class, and also added support for sharded specs directories.Fixes CocoaPods/CocoaPods#5062.