Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Use new Pod::Source::Manager #275

Merged
merged 2 commits into from
Apr 15, 2016
Merged

Use new Pod::Source::Manager #275

merged 2 commits into from
Apr 15, 2016

Conversation

nwest
Copy link
Member

@nwest nwest commented Apr 1, 2016

Closes #273.

This PR depends on CocoaPods/Core#316. We'll have to wait until we get the next CocoaPods release in the app for this PR.

@@ -62,7 +62,7 @@ def self.analyze_podfile(podfile, installation_root)
end

def self.all_pods
Pod::SourcesManager.aggregate.all_pods
Pod::Source::Manager.aggregate.all_pods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will crash -- I'd use Pod::Config.instance.sources_manager.aggregate.all_pods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nwest nwest force-pushed the sources_manager branch from cb85385 to c96a904 Compare April 1, 2016 22:03
@endocrimes
Copy link
Member

🍏 - Good to merge when CocoaPods/Core#316 is in

@segiddins
Copy link
Member

Should this be merged now?

@nwest
Copy link
Member Author

nwest commented Apr 14, 2016

I'm not sure why the SSL changes are causing problems with this build. I haven't had a chance to look into it.

@segiddins
Copy link
Member

Fyi, beta 7 has now been released

@nwest nwest force-pushed the sources_manager branch from cda5fe7 to fffea46 Compare April 15, 2016 18:33
@orta
Copy link
Member

orta commented Apr 15, 2016

The version bump is a bit more complex than that, but I'll take it 💃

@orta orta merged commit 6bc89a4 into master Apr 15, 2016
@segiddins segiddins deleted the sources_manager branch April 15, 2016 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants