Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vogue, add Janus #96

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Remove Vogue, add Janus #96

merged 1 commit into from
Feb 7, 2024

Conversation

ivadym
Copy link

@ivadym ivadym commented Feb 6, 2024

Description

Added

  • janus as a valid tag for the used_by field

Removed

  • vogue tag

How to prepare for test

  • ssh to hasta.scilifelab.se
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_hermes -t hermes -b [THIS-BRANCH-NAME]

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch
  • Inform to ...

@ivadym ivadym requested a review from ChrOertlin February 6, 2024 15:40
@ivadym ivadym self-assigned this Feb 6, 2024
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ivadym ivadym merged commit 34d376a into main Feb 7, 2024
2 checks passed
@ivadym ivadym deleted the add-janus branch February 7, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants