Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store intermediate MultiQC files for Balsamic #95

Merged
merged 14 commits into from
Feb 21, 2024
Merged

Conversation

ivadym
Copy link

@ivadym ivadym commented Feb 6, 2024

Description

Added:

  • MultiQC intermediate files to HK

How to prepare for test

  • ssh to hasta.scilifelab.se
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_hermes -t hermes -b [THIS-BRANCH-NAME]

How to test

  • Store files in HK

Expected test outcome

  • Check that all the relevant files has been added to the bundle (TO-panel)
    Screenshot 2024-02-19 at 15 41 58

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch
  • Inform to ...

@ivadym ivadym requested a review from a team as a code owner February 16, 2024 14:00
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22ae40d) 90.16% compared to head (7993934) 90.16%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files          25       25           
  Lines         559      559           
=======================================
  Hits          504      504           
  Misses         55       55           
Flag Coverage Δ
unittests 90.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup! 👍 It will be easier to create models in Janus if the tags etc are made into enums.

@ivadym ivadym merged commit 0ffb307 into main Feb 21, 2024
2 checks passed
@ivadym ivadym deleted the add-multiqc-files branch February 21, 2024 15:30
@ivadym
Copy link
Author

ivadym commented Feb 21, 2024

Deployed
Screenshot 2024-02-21 at 16 36 20
d:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

4 participants