Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos builds from using ungated std::filesystem calls in cata_imgui #75986

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

akrieger
Copy link
Member

Summary

None

Purpose of change

Fixes

/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/filesystem:909:24: note: 'path' has been explicitly marked unavailable here
class _LIBCPP_TYPE_VIS path {
                       ^
Error: src/cata_imgui.cpp:275:37: error: 'exists' is unavailable: introduced in macOS 10.15
            return std::filesystem::exists( path );

from #75937

Describe the solution

Use the wrappers we have.

Describe alternatives you've considered

Testing

make RELEASE=1 TILES=1 LOCALIZE=0 SOUND=1 -j10 CCACHE=1 obj/tiles/cata_imgui.o locally.

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 27, 2024
@Maleclypse Maleclypse merged commit 871d063 into CleverRaven:master Aug 27, 2024
29 checks passed
@akrieger akrieger deleted the stdfsck branch August 28, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants