Check the typeface file exists #75937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alef
added a commit
to alef/Cataclysm-DDA
that referenced
this pull request
Aug 26, 2024
* Check the typeface file exists * Obey lint
Knut-Aage-Hofseth
pushed a commit
to Knut-Aage-Hofseth/Cataclysm-DDA
that referenced
this pull request
Aug 29, 2024
* Check the typeface file exists * Obey lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Check the typeface file exists"
Purpose of change
@NetSysFire reported a crash after #75920.
AddFontFromFileTTFaborts if the file path to the font does not exists.Describe the solution
load_fontsnow use the first existing typeface path instead of the user's first one which may be invalid.unifontis already forcibly added so we assume there will be always a valid typeface.Describe alternatives you've considered
Testing
Built with vscode+cmake on Windows. fonts.json.typeface to contain invalid path. Game loads using next existing font file.
Additional context