Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments describing use of vision levels #75429

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

ehughsbaird
Copy link
Contributor

Summary

None

Purpose of change

It was requested that I add comments to these so that it's more clear which one to apply to new overmap terrains.

Describe the solution

Add comments.

So it's clear what should be applied to new overmap terrains, instead of
guessing or leaving it vacant.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 3, 2024
Copy link
Member

@harakka harakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the sort of thing I had in mind, thanks!

@dseguin dseguin merged commit 9f15085 into CleverRaven:master Aug 5, 2024
20 of 26 checks passed
@ehughsbaird ehughsbaird deleted the describe-levels branch August 5, 2024 00:29
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants