Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Hub 01 armor repair fees and timeframes #75033

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jul 15, 2024

Summary

Balance "update Hub 01 armor repair fees and timeframes"

Purpose of change

While working on #74962 it came to my knowledge that the repair times and fees for our current armor repairs have been greatly underestimated.

Describe the solution

The first time the phase suit and rm13 are repaired, the fee will be 12 coins and the repair times a month and a half.

Once the repairs have been done at least once, the armors are considered "reverse-engineered", from this point onward following repairs will only take 2 weeks, and cost 10 coins.

I also took the liberty of removing one of the conditional dialogue to check on how the repairs are going, we only need one dialogue to check, and the check as also been simplified, now we only check if the armor is currently an ongoing project.

The timers setups and timer checks have been slightly modified to accommodate the different dialogue options.

Describe alternatives you've considered

  • Instead of having the different variables be stored on the player have them stored on the npc the same way I did with the reverse-engineered variables, for better interactions with character swapping. Not sure how to go about it yet, and is out of scope anyway.

Testing

Spawned char, spawned Hub 01, talked with intercom, stuff seems to work ok. I touched a few variables since then but it should work the same.

Additional context

The writing is awful, feel free to suggest better dialogue.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 15, 2024
@BalthazarArgall BalthazarArgall marked this pull request as ready for review July 15, 2024 13:23
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 15, 2024
@Maleclypse Maleclypse merged commit 8b1fce9 into CleverRaven:master Jul 16, 2024
31 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants