Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make salvaged combat exoskeletons repairable #74962

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented Jul 9, 2024

Summary

Features "Make salvaged combat exoskeletons repairable"

Purpose of change

We have salvaged combat exoskeletons in the game but they're mostly useless, you can technically use them as a platform for exoskeleton armor plating but at this point you're better off using any other armor. Especially since armor platings are extremely hard to find outside of fully functional exoskeletons spawning with them.

Describe the solution

I made it so you can ask Hub 01 to repair your exoskeleton, mostly copying and modifying already existing dialogue for repairing the RM13 and Phase Suit.

The cost is double because while exoskeleton technology is advanced, it's not the near-sci-fi levels of the RM13 or the phase suit and the Hub wouldn't have much to gain in studying them, reparation is mostly a service to the player (the guy at the intercom won't be very excited about it, wow such great writing).

The repair time has been kept the same as the other armors due to the nanofabricator being almost certainly used to repair the item and making repairs trivial.

I changed a few minor things about the salvaged exoskeleton item itself, it now represents the environmental suit but has 50% coverage on it due the irreparable (by the player) damage to the suit.

Describe alternatives you've considered

  1. Add different versions of salvaged exoskeletons. It's a lot of work for a small payoff, the mk1-2 versions were way less popular than the mk3 in universe, we could add two other types of armored zombies to represent them but they would be so rare that they wouldn't be worth simulating in my opinion.

Testing

Tested the dialogue individually, works perfectly. Tested the armor, no error on load anymore, worn without issues.

Additional context

Some dialogue authored by SomeGuy. #75033 needs to be merged first

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • 'One moment,' the respondant audibly leaves for a moment and after a short period the intercom cracks with life.' The exoskeleton will require parts that involve hands-on production and machining. It will cost you two coins, and should be ready within two days. Please make sure to take off any attachments or batteries before turning it in.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@BalthazarArgall BalthazarArgall marked this pull request as ready for review July 10, 2024 00:38
@kevingranade
Copy link
Member

Two days for repairing a heavily damaged piece of very complex kit is an absolutely ludicrous turn around time, this is something that would require a month or more because they're having to reverse engineer and fabricate components for the thing. Even that is honestly super short and not really factoring in "just how much time are they willing to spend on this". The cost is likewise crazy low.

@BalthazarArgall
Copy link
Contributor Author

BalthazarArgall commented Jul 10, 2024

Two days for repairing a heavily damaged piece of very complex kit is an absolutely ludicrous turn around time, this is something that would require a month or more because they're having to reverse engineer and fabricate components for the thing. Even that is honestly super short and not really factoring in "just how much time are they willing to spend on this". The cost is likewise crazy low.

I went full cargo cult on this, is there something fundamentally different about repairing the RM13 and phase suit compared to the combat exoskeleton? If anything I would think the combat exos would be less complex/easier to repair.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 10, 2024
@BalthazarArgall BalthazarArgall marked this pull request as draft July 10, 2024 09:29
@John-Candlebury
Copy link
Member

If the complexity is required I'd go for a month and a few weeks first time and just a pair of weeks everytime after that. I dont know what the time for the other two suits is, but it should also be a pair of weeks.

I'd go with between 10 and 12 coins for the cost, the economy in general is still very bad with no guidelines on how to price things, so I wouldnt really about finetuning the cost too much.

@BalthazarArgall
Copy link
Contributor Author

If the complexity is required I'd go for a month and a few weeks first time and just a pair of weeks everytime after that. I dont know what the time for the other two suits is, but it should also be a pair of weeks.

I'd go with between 10 and 12 coins for the cost, the economy in general is still very bad with no guidelines on how to price things, so I wouldnt really about finetuning the cost too much.

Got it. o7

Co-authored-by: SomeGuyIGues <154325171+SomeGuyIGues@users.noreply.github.com>
@BalthazarArgall BalthazarArgall marked this pull request as ready for review July 11, 2024 15:25
@BalthazarArgall BalthazarArgall marked this pull request as draft July 12, 2024 09:18
@PatrikLundell
Copy link
Contributor

A fundamental difference between repairing their own "products" and the suit is that they don't have the "blueprints" for either the suit itself or its parts, so they would have to be developed (basically saying the same thing as @kevingranade did above).

While we obviously don't know how a nano fabricator is supposed to work, I would assume it's not magic, but rather an extremely advanced 3D printer capable of handling multiple materials and parts. I can't see how such an item could repair anything (imagine trying to use a 3D printer to repair something it made) without someone first specifying what to repair and how to do it. A 3D printer wouldn't be able to repair anything it can't reach (such as parts now obstructed by layers deposited later), while a fabricator potentially could be instructed to take the item apart to reach the things to repair.

@BalthazarArgall BalthazarArgall marked this pull request as ready for review July 16, 2024 07:29
@Maleclypse Maleclypse merged commit 07bcddc into CleverRaven:master Jul 19, 2024
27 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants