Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11306: hakuvahti fixes #1162

Merged
merged 2 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/js/job-search.min.js

Large diffs are not rendered by default.

116 changes: 0 additions & 116 deletions src/js/react/apps/job-search/containers/PromotedResultsContainer.tsx

This file was deleted.

111 changes: 99 additions & 12 deletions src/js/react/apps/job-search/containers/ResultsContainer.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,106 @@
import { useAtomValue } from 'jotai';
import { useAtomValue, useSetAtom } from 'jotai';
import { SyntheticEvent, createRef } from 'react';

import SimpleResultsContainer from './SimpleResultsContainer';
import PromotedResultsContainer from './PromotedResultsContainer';
import { configurationsAtom } from '../store';
import Pagination from '@/react/common/Pagination';
import ResultWrapper from '@/react/common/ResultWrapper';
import useScrollToResults from '@/react/common/hooks/useScrollToResults';
import ResultsError from '@/react/common/ResultsError';
import Global from '../enum/Global';
import URLParams from '../types/URLParams';
import { configurationsAtom, pageAtom, setPageAtom, urlAtom } from '../store';
import useIndexQuery from '../hooks/useIndexQuery';
import useResultsQuery from '../hooks/useResultsQuery';
import ResultsSort from '../components/results/ResultsSort';
import ResultsList from '../components/results/ResultsList';
import ResultsHeader from '@/react/common/ResultsHeader';
import ResultsEmpty from '@/react/common/ResultsEmpty';
import SearchMonitorContainer from './SearchMonitorContainer';

const ResultsContainer = () => {
const { promoted } = useAtomValue(configurationsAtom);

return promoted?.length ?
<PromotedResultsContainer /> :
<>
{drupalSettings?.helfi_react_search?.hakuvahti_url_set && <SearchMonitorContainer />}
<SimpleResultsContainer />
</>;
const { size } = Global;
const urlParams: URLParams = useAtomValue(urlAtom);
const currentPage = useAtomValue(pageAtom);
const setPage = useSetAtom(setPageAtom);
const { error: initializationError } = useAtomValue(configurationsAtom);
const scrollTarget = createRef<HTMLDivElement>();
const { query, promoted, handleResults } = useResultsQuery(urlParams);

// Scroll to results when they change.
const choices = Boolean(Object.keys(urlParams).length);
useScrollToResults(scrollTarget, choices);

const { data, error, isLoading, isValidating } = useIndexQuery({
keepPreviousData: true,
query,
multi: promoted
});

const updatePage = (e: SyntheticEvent<HTMLButtonElement>, index: number) => {
e.preventDefault();
setPage(index.toString());
};

const getResults = () => {
if (!data && !error) {
return;
}

if (error || initializationError || data.error) {
return (
<ResultsError
error={error || initializationError || data.error}
className='react-search__results'
ref={scrollTarget}
/>
);
}

const { results, jobs, total } = handleResults(data);

if (total <= 0) {
return <ResultsEmpty wrapperClass='hdbt-search--react__results--container' ref={scrollTarget} />;
}

const pages = Math.ceil(total / size);

return (
<>
<ResultsHeader
resultText={
<>
{ Drupal.formatPlural(jobs, '1 open position', '@count open positions',{},{ context: 'Job search results statline' }) }
</>
}
optionalResultsText={
<>
{ Drupal.formatPlural(total, '1 job listing', '@count job listings',{},{context: 'Job search results statline'}) }
</>
}
actions={<ResultsSort />}
actionsClass="hdbt-search--react__results--sort"
ref={scrollTarget}
/>
<ResultsList hits={results} />
<Pagination
currentPage={currentPage}
pages={5}
totalPages={pages}
updatePage={updatePage}
/>
</>
);
};

return (
<>
{drupalSettings?.helfi_react_search?.hakuvahti_url_set && <SearchMonitorContainer />}
<div className='job-search__results'>
<ResultWrapper loading={isLoading || isValidating}>
{getResults()}
</ResultWrapper>
</div>
</>
);
};

export default ResultsContainer;
106 changes: 0 additions & 106 deletions src/js/react/apps/job-search/containers/SimpleResultsContainer.tsx

This file was deleted.

2 changes: 2 additions & 0 deletions src/js/react/apps/job-search/hooks/useIndexQuery.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import Global from '../enum/Global';
import useTimeoutFetch from '@/react/common/hooks/useTimeoutFetch';

type UseIndexQueryProps = {
// Keep previous result while revalidating from swr.
keepPreviousData?: boolean
// Uses _mquery endpoint if true
multi?: boolean;
// Elastic query
Expand Down
6 changes: 2 additions & 4 deletions src/js/react/apps/job-search/hooks/usePromotedQuery.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import Global from '../enum/Global';
import IndexFields from '../enum/IndexFields';
import URLParams from '../types/URLParams';
import useQueryString from './useQueryString';

const usePromotedQuery = (urlParams: URLParams): string => {
const usePromotedQuery = (baseQuery: string, urlParams: URLParams): string => {
const { size } = Global;
const page = Number.isNaN(Number(urlParams.page)) ? 1 : Number(urlParams.page);
const baseQuery = useQueryString(urlParams);
const promotedQuery = JSON.parse(baseQuery);

const promotedClause = {
term: {
[IndexFields.PROMOTED]: true
Expand Down
Loading
Loading