Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-11306
What was done
Hakuvahti is not shown if any job advert has
field_promoted
set to true due to logic inResultsContainer.tsx
.This change refactors results container so that there is only one component for displaying results instead of two that are mostly similar. The actual logic that needs to be different was split into
useResultsQuery()
.How to install
git pull origin dev
make fresh
composer require drupal/hdbt:dev-UHF-11306-hakuvahti-fixes
make drush-cr
How to test
field_promoted
set to false:drush sql:q "SELECT COUNT(*) FROM node__field_promoted WHERE bundle = 'job_listing' AND field_promoted_value <> 0;"
(Find and remove if the query returns anything but zero).
drush sapi-rt; drush sapi-c; drush sapi-i
drush sapi-i
.Continuous documentation
Translations
Other pull requests