Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Empty Response Body and 0 Content Lenght #206

Merged
merged 6 commits into from
Jan 25, 2020
+36 −49
Merged

Fix for Empty Response Body and 0 Content Lenght #206

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fc53fb
Rewrite the processResponseBody method as it's broken
cortinico Jan 24, 2020
1bd062c
KtLint fix
cortinico Jan 24, 2020
6ba8061
Make sure ChuckerInterceptor is after the LoggingInterceptor
cortinico Jan 25, 2020
a9b83c1
Applying @vbuberen suggestions
cortinico Jan 25, 2020
db8a9cc
Make check for image content type case-insensitive
vbuberen Jan 25, 2020
808c6b6
Fix detekt issue
vbuberen Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make check for image content type case-insensitive
@vbuberen
vbuberen authored Jan 25, 2020
commit db8a9cc0da55634914ac8a10646c44f8804051fc
2 changes: 1 addition & 1 deletion library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt
View file
Original file line number Diff line number Diff line change
@@ -158,7 +158,7 @@ class ChuckerInterceptor @JvmOverloads constructor(
} else {
transaction.isResponseBodyPlainText = false

val isImageContentType = (transaction.responseContentType?.contains(CONTENT_TYPE_IMAGE) == true)
val isImageContentType = (transaction.responseContentType?.contains(CONTENT_TYPE_IMAGE, ignoreCase = true) == true)
if (isImageContentType && buffer.size() < MAX_BLOB_SIZE) {
transaction.responseImageData = buffer.readByteArray()
}