Fix for Empty Response Body and 0 Content Lenght #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've rewrote the processResponseBody following the body of HttpLoggingInterceptor.
vbuberen
reviewed
Jan 25, 2020
This was referenced Jan 25, 2020
Closed
vbuberen
reviewed
Jan 25, 2020
library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt
Outdated
Show resolved
Hide resolved
vbuberen
reviewed
Jan 25, 2020
vbuberen
reviewed
Jan 25, 2020
vbuberen
reviewed
Jan 25, 2020
library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduce by me in #198, when implementing clone of the
okio.Bufferfrom the HTTP Response.Looks like the problem on our end what that we were using
ChuckerInterceptoras first interceptors, so the Sample App showed valid results. Switching order of the interceptors showed that responses arenulland the approach followed for the.clone()was not correct. I reimplemented it following theHttpLoggingInterceptorbody.How to test
Remove the fix I applied on
ChuckerInterceptorand keep only the changes I applied in the sample app. It should break and shownullin the response body.Fixes #203
Closes #205