Visibility fix for internal members #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
reviewed
Jan 7, 2020
| @@ -8,7 +8,7 @@ android { | |||
| compileSdkVersion rootProject.compileSdkVersion | |||
|
|
|||
| compileOptions { | |||
| kotlinOptions.freeCompilerArgs += ['-module-name', "com.github.ChuckerTeam.Chucker.library-no-op"] | |||
There was a problem hiding this comment.
Unfamiliar with what's going on here. Can someone explain?
|
@cortinico This PR is ready for review. |
kmayoral
pushed a commit
to kmayoral/chucker
that referenced
this pull request
Jan 21, 2020
* Fix visibility modifiers for internal package members * Fix typo in module name, replace deprecated methods * Fix for detekt issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
Fixes #179
📝 Changes
ViewModelthis fun was reverted to state before Unification for activities start #137