Unification for activities start #137
Conversation
| private const val EXTRA_THROWABLE_ID = "EXTRA_THROWABLE_ID" | ||
| private const val TEXT_PLAIN = "text/plain" |
There was a problem hiding this comment.
Can you move all the constants to the companion? To standardize it.
There was a problem hiding this comment.
Sure. I just thought that classes had such constants declaration, because you prefer to avoid companion objects when possible, like some devs do (for example: https://medium.com/@BladeCoder/exploring-kotlins-hidden-costs-part-1-fbb9935d9b62 ).
As to this particular constant for TEXT_PLAIN - I wanted to remove it in another PR, but for now will just move it.
|
|
||
| private const val ARG_TRANSACTION_ID = "transaction_id" | ||
| private var selectedTabPosition = 0 |
There was a problem hiding this comment.
Oh! I just found something... interesting 👀
I guess the previous developer used selectedTabPosition as a static in order to store in memory. And used it when view needs to re-open (in setupViewPager).
For this PR, could you let selectedTabPosition in the companion? I'm not fan of the idea, but for now I just want to merge this PR.
There was a problem hiding this comment.
Yeah, I also not a big fan of such idea, but let's do for this PR.
|
Thanks, again 👍 |
Minor set of changes to make a unified way of how
TransactionActivityandErrorActivitystart, since after recent merges these operations looked quite different.