feat(about): render images in markdown #5732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5710
Description
It looks to me that why it works in the "Support" section is because it's using
this.markdownService.enhancedMarkdownToHTML()
https://github.com/Chocobozzz/PeerTube/blob/00ee545c2444c35ed0d37df9f91984246aa36124/client/src/app/shared/shared-support-modal/support-modal.component.ts
which has different rules set in
PeerTube/shared/core-utils/renderer/markdown.ts
Line 17 in 00ee545
image
So I changed the relevant line for the "About" page fields and now it works 🎊
Related issues
#5710
Has this been tested?
Do we need to run or have a test for this?
Screenshots
Before
After