Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in Markdown or in HTML #5710

Closed
Alterak opened this issue Mar 24, 2023 · 3 comments · Fixed by #5732
Closed

Images in Markdown or in HTML #5710

Alterak opened this issue Mar 24, 2023 · 3 comments · Fixed by #5732

Comments

@Alterak
Copy link
Contributor

Alterak commented Mar 24, 2023

Describe the problem to be solved

In the Support section (for a channel or for a video) it is possible to add an image, for example like this:
![альт](https://peervideo.ru/static/st-files/donate.png "Donate")
Also in the NGINX configuration file I added a directory of static files "st-files"

  # Bypass PeerTube for performance reasons. Optional.
  location ~ ^/static/(thumbnails|avatars|st-files)/ {

This works fine, but only for the "Support" section

Now I want in the description of my server, in the Financing section of Pertube I want to also add an image (barcode). I may want to add an image in other sections of my server description, but I can't do that because there is no such image support there.

Describe the solution you would like

A big request is to add support for images in all sections of the server where Markdown or HTML support is used. If this violates security, then you can add this item to the Peertube configuration so that the administrator decides what to choose (either Yes or No).

@Jolg42
Copy link
Contributor

Jolg42 commented Apr 4, 2023

I created my first PR on PeerTube for this here #5732

Chocobozzz pushed a commit that referenced this issue Apr 5, 2023
* feat(about): render images in markdown

Closes #5710

* Update edit-instance-information.component.html

* use `markdownType="enhanced"`
@Alterak
Copy link
Contributor Author

Alterak commented May 29, 2023

I created my first PR on PeerTube for this here #5732

Thank you for this functionality!
Can you tell me how to control the image size?

@Chocobozzz
Copy link
Owner

You can't, please create another issue. markdown-it/markdown-it#80 (comment) might be the way to handle this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants