Add warning and update privacy on share playlist #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds great to me :) |
|
Hello and thanks for the PR. Instead of creating another form in this modal which increase maintenance work, could you just display the message with a Something like "This playlist is private, you can update its privacy on <a..." |
|
@Chocobozzz Sure! It's looking like this |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to solve the issue #3976
The feature that is implemented warns the users about the playlist being on private mode and also allows them to directly update the privacy to Public. In order to immediately be able to share the playlist.
Related issues
Issue #3976
Has this been tested?
Screenshots
See a video of how is working here:
Playlist.elements.-.PeerTube.mp4