Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder that playlist is private in share modal #3976

Closed
MyNameIsTroll opened this issue Apr 17, 2021 · 4 comments
Closed

Add reminder that playlist is private in share modal #3976

MyNameIsTroll opened this issue Apr 17, 2021 · 4 comments

Comments

@MyNameIsTroll
Copy link

Describe the problem to be solved
I have little experience with playlists on Peertube.
By default, when I create a playlist it is in "private" mode.
A few days later, I try to share my playlist, I press the "share" button, I get a sharing link.
Except that my playlist is in "private" mode... so if I share this link my friends will see a 404 error.

Describe the solution you would like:
2 things could be improved in my opinion.

The first is that we could warn the user when he presses the button to create a sharing link that his playlist is in "private" mode and that this link will only be visible to him. he is connected to his account.
Otherwise, invite him to change the state of his playlist from private mode to public or unlisted mode.

Second, if it continues its process anyway and shares a "private" playlist link and someone follows the link and lands on the 404 error page, we might be able to mention in the errors possible on page 404 "this may be a private mode playlist".

image
image

@rigelk rigelk changed the title Alert when a link is created to share a playlist in private mode Add reminder that playlist is private in share modal Apr 17, 2021
@Chocobozzz Chocobozzz added good first issue Priority: High UI non-trivial UI changes, that might need discussion labels Apr 18, 2021
@natar10
Copy link
Contributor

natar10 commented Oct 17, 2021

Hey! Do you still need help with this issue?

@Chocobozzz
Copy link
Owner

@natar10 yes, you can create a PR if you want

@natar10
Copy link
Contributor

natar10 commented Oct 19, 2021

Hello there! I opened the PR with a possible solution here

Please let me know any comments. Thank you!

@Chocobozzz
Copy link
Owner

Fixed by #4469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants