Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-widgets][react-redux] Export missing types from v2.3.9 #833

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

donmccurdy
Copy link
Member

Description

Followup to:

These type definitions were exported from their declarations, but not re-exported from the indexes above them. This change does not block any functionality in the current Builder iteration, but just cleans up some duplicate type information So there is no rush to cut a v2.3.10 release.

Type of change

Fix (type definitions)

Acceptance

n/a, tested against feature branch locally.

@donmccurdy donmccurdy requested a review from a team January 30, 2024 18:13
Copy link

Pull Request Test Coverage Report for Build 7715602273

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.226%

Totals Coverage Status
Change from base Build 7710981155: 0.0%
Covered Lines: 2613
Relevant Lines: 3450

💛 - Coveralls

Copy link

Visit the preview URL for this PR (updated for commit 74cd6cc):

https://cartodb-fb-storybook-react-dev--pr833-donmccurdy-types-9zcoebca.web.app

(expires Tue, 06 Feb 2024 18:19:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

Copy link
Contributor

@padawannn padawannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @donmccurdy

@donmccurdy donmccurdy merged commit 3d857b0 into master Jan 31, 2024
2 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/types-reexport-v2.3.9 branch January 31, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants